Copilot remains active despite being turned off in local settings

[lum1n]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

When opening an existing project with local zed settings and copilot turned off, it does not recognize being turned off before opening local settings.

.zed/settings.json:

{
    "features": {
        "copilot": false
    }
}

~/.config/zed/setting.json:

{
    "features": {
        "copilot": true
    }
}

Environment

Zed: 0.127.1 (preview)
MacOs: 14.4
Macbook M1 Max

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

[Moshyfawn]

Reproduction steps:

1. Open a project.
   1.1. Make sure that Copilot is enabled in your global settings.
2. Create .zed/settings.json.

{
  "show_copilot_suggestions": false
}

3. Close the settings.json file.
4. Restart Zed.
5. See that the Copilot icon is enabled.

[JosephTLyons]

cc @SomeoneToIgnore, since this issue was closed out:

• Hint still showing after disabling copilot #6793

[JosephTLyons]

@lum1n, does the global setting to turn copilot suggestions off work? I'm curious if this is a bug with the logic, or if maybe the local settings just don't support this setting yet. I think at the moment, unless something has changed since I last knew, local settings don't include all global settings, and maybe this copilot one is one of those not supported.

[SomeoneToIgnore]

I fail to reproduce it on the latest Preview with default settings and show_copilot_suggestions:
https://github.com/zed-industries/zed/assets/2690773/241e5d8a-d744-45fd-a81f-45a1c9a9243f

so wonder what am I doing wrong?

[Moshyfawn]

so wonder what am I doing wrong?

It looks like you left the settings.json file open before restarting the editor.

[SomeoneToIgnore]

I have tried a few more times, closing all files did not help to repro this either:

Screen.Recording.2024-03-14.at.22.10.41.mov

also, tried cmd-q instead of the restart action, but that also did not change much.

What I did notice, is that despite currently opened project files had the disabled copilot, opening "internal" Zed files like settings.json had copilot enabled, switching tabs changed the copilot icon:

Untitled.mov

So, there seems to be some worktree-related oddity with Copilot and settings.

But this issue seems to be about files from the same worktree ("project")?

[lum1n]

@lum1n, does the global setting to turn copilot suggestions off work? I'm curious if this is a bug with the logic, or if maybe the local settings just don't support this setting yet. I think at the moment, unless something has changed since I last knew, local settings don't include all global settings, and maybe this copilot one is one of those not supported.

I actually haven't tried disabling suggestions only. In my case, i am not allowed to use AI on this specific codebase, so i find it a bit unsettling that i suddenly get suggestions even though i have disabled copilot locally. If i open .zed/settings.json once, it gets disabled. But i have to remember doing that every time. And today it suddenly activated mid session as well. So, have to disable it globally.

Also, disabling suggestions only, i suppose that will still leave copilot "activated" for the project?

[OSuwaidi]

I am facing the same issue.

Before a few updates ago, the following setting would disable copilot and hide its icon from the status bar:

{
  "features": {
    // Show Copilot icon in status bar
    "copilot": false
  },
}

This seems not to have an effect anymore as it no longer exists in Zed's Default Settings json file.

[notpeter]

Good morning all, could you please alter your settings to use the following values and report back.

rename features.copilot to inline_completions

{
  "features": {
    "inline_completions": "none"
  },
}

rename show_copilot_suggestions to show_inline_completions

{
  "show_inline_completions": false
}

We attempted to rename these values in a backwards compatible way (leveraging a serde alias feature) and ultimately that caused a host of new issues for users so we've decided to just deprecate the old settings values altogether. This may or may not solve your issue, but you should migrate your settings and cease usage of features.copiolot, show_copilot_suggestions as they will be no-ops going forward.

Similarly, please move any language_overrides into languages.

We understand this a PITA and are using this as a learning opportunity to better for how we handle migrations and settings compatibility going forward. Please bear with us.

Context:

• Settings Deprecation Notice 2024-06-17: language_overrides, show_copilot_suggestions and features.copilot #13171

[tv42]

To get rid of the copilot icon in status bar, try

"features": {
  "inline_completion_provider": "none"
}

from #7121 (comment)