add tests with Rails 7.2 and 8.0, handle deprecations in tests #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
reviewed
Nov 19, 2024
Dynamic :controller and :action segments have been deprecated. We replace them with a static list of routes that we use in tests. Another deprecation is “`to_time` will always preserve the receiver timezone rather than system local time in Rails 8.1”. We don’t really care one way or another in this test app, so we opt in for the new behaviour.
razumau
force-pushed
the
jury.razumau/rails8.0
branch
from
e1fd24d
to
7938163
Compare
bquorning
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes on deprecations:
:controllerand:actionsegments have been deprecated. We replace them with a static list of routes that we use in tests.to_timewill always preserve the receiver timezone rather than system local time in Rails 8.1”. We don’t really care one way or another in this test app, so we opt in for the new behaviour.