Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer reset not needed on a :not_coordinator according to librdkafka #301

Open
mensfeld opened this issue Sep 22, 2022 · 1 comment
Open

Comments

@mensfeld
Copy link

mensfeld commented Sep 22, 2022

This code:

https://github.com/zendesk/racecar/blob/master/lib/racecar/consumer_set.rb#L165

handles the not_coordinator by resetting the consumer.

Based on this comment:

confluentinc/librdkafka#2630 (comment)

Huhm, it seems like the coordinator is not re-queried when we get a NOT_COORD_FOR_GROUP error for OffsetCommitRequests, but it will be re-queried when we get the same error for HeartbeatRequests so the situation should fix itself within the heartbeat interval (by default within a couple of seconds).

Here it's about the not coord for group but the same principle of metadata state refresh applies to not_coord.

The consumer should reset itself without a need for a new instance.

Do you want me to fix this?

@dasch
Copy link
Contributor

dasch commented Oct 3, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants