[APPS-6946] Add manifest validation to deprecate password type param #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aishkan
changed the title
mmassaki
approved these changes
Sep 17, 2024
JeanMarcGoepfert
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @zendesk/wattle
Description
Add manifest validation to disallow password type params.
The check is based on enabling _password_parameter_check to ensure this validation works only for new app submission. The value will be passed in from Apps approval and ZAM.
The apply _password_parameter_check value will be passed in from Apps Approval gem here.
References
https://zendesk.atlassian.net/browse/APPS-6946
Risks
[RUNTIME] No
[low] Only adds an extra validation in manifest that works dependant on skip_password_parameter_check. Manifest validation can fail for apps.