Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Santa ballot box bug #1086

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix Santa ballot box bug #1086

merged 2 commits into from
Nov 27, 2024

Conversation

np5
Copy link
Member

@np5 np5 commented Nov 25, 2024

The reset checks where not done per configuration, but globally.

@coveralls
Copy link

coveralls commented Nov 25, 2024

Pull Request Test Coverage Report for Build 12053865610

Details

  • 59 of 59 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 80.907%

Totals Coverage Status
Change from base Build 11973691032: 0.01%
Covered Lines: 38523
Relevant Lines: 47614

💛 - Coveralls

The reset checks where not done per configuration, but globally.
Re-compute all the rules for each update to avoid errors when signing id
or binary targets are shared by multiple metabundles or bundles.

Also add rule events to ballot box

More tests
Copy link
Collaborator

@headmin headmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@np5 np5 merged commit 8892ca8 into main Nov 27, 2024
10 checks passed
@np5 np5 deleted the 20241125_santa_fixes branch November 27, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants