Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is ZEPHYR_BASE hard coded? #162

Open
NINI1988 opened this issue Sep 8, 2023 · 2 comments
Open

Why is ZEPHYR_BASE hard coded? #162

NINI1988 opened this issue Sep 8, 2023 · 2 comments

Comments

@NINI1988
Copy link

NINI1988 commented Sep 8, 2023

In

ENV ZEPHYR_BASE=/workdir/zephyr

ZEPHYR_BASE is hard coded and prevents the usage of my .west/config file:

[zephyr]
base = deps/zephyr

Without the hard coded ZEPHYR_BASE, west will automatically find zephyr.base from the config file and does't require this. Is there a reason for that? I have zephyr under folder deps, so the hard code path does not exists.

I would like to extend the already build image from ghcr.io/zephyrproject-rtos/zephyr-build:v0.26.4 and extend that for my usage.
But it is not possible in docker to unset an env variable (https://stackoverflow.com/questions/55789409/how-to-unset-env-in-dockerfile).
Otherwise I have to call unset ZEPHYR_BASE before every command.

@stephanosio
Copy link
Member

stephanosio commented Feb 7, 2024

It mostly has to do with the (quite outdated and far from ideal) instructions given in the README.

I am not against the idea of removing ENV ZEPHYR_BASE since not doing so reduces the reusability of the image -- we just need to update the instructions in the README accordingly.

@kaizoku-oh
Copy link

Did you find a way around that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants