Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always decode manifests with utf-8; not just most of the time #711

Merged
merged 3 commits into from
Jun 26, 2024

Commits on May 28, 2024

  1. manifest: add new local constant "git_filenames_encoding"

    Cosmetic fix, no functional change. A little less duplication and
    hardcoding.
    
    listdir_at() had an optional "encoding" parameter but it was never used
    before now, always defaulting to 'utf-8'.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed May 28, 2024
    Configuration menu
    Copy the full SHA
    94dcb58 View commit details
    Browse the repository at this point in the history
  2. manifest: add new Manifest.encoding constant = 'utf-8'

    No functional change: just a lot less duplication & hardcoding.
    
    This can help testing and supporting other encodings. It does not hurt
    in any case.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed May 28, 2024
    Configuration menu
    Copy the full SHA
    645e7a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. project: use new Manifest.encoding constant (utf-8) to read manifest

    Fixes issue reported in PR zephyrproject-rtos#710 where most places are hardcoded to
    'utf-8' while this one is (Windows) locale-dependent. In the future, we
    may want to make this more flexible but the most urgent fix is
    consistency: with this commit, manifest decoding should be hardcoded to
    'utf-8' everywhere.
    
    Signed-off-by: Marc Herbert <marc.herbert@intel.com>
    marc-hb committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    6726319 View commit details
    Browse the repository at this point in the history