Provide resizeterm function
#40
Labels
enhancement
New feature or request
Comments
cas--
added a commit
to deluge-torrent/deluge
that referenced
this issue
Sep 8, 2024
Testing with window-curses results in hangs on initial loading with background error:
File "C:\Users\Docker\Deluge\.venv\lib\site-packages\twisted\internet\selectreactor.py", line 39, in win32select
r, w, e = select.select(r, w, w, timeout)
builtins.OSError: [WinError 10038] An operation was attempted on something that is not a socket
This is due to passing a Console class to addReader but this fails since
select on Windows cannot handle non-socket file object unlike Unix which accepts
sockets and file objects.
There is likely a further issue where windows-curses has not implemented
resizeterm so would need to use resize_term instead.
Refs: https://docs.python.org/3/library/select.html#select.select
Refs: https://stackoverflow.com/questions/11731175/python-twisted-addreader-works-in-linux-but-not-windows
Refs: zephyrproject-rtos/windows-curses#40
Refs: https://docs.python.org/3/library/curses.html#curses.resize_term
Closes: #457
Co-authored-by: Calum Lind <calumlind+deluge@gmail.com>
doadin
pushed a commit
to doadin/deluge
that referenced
this issue
Sep 21, 2024
Testing with window-curses results in hangs on initial loading with background error:
File "C:\Users\Docker\Deluge\.venv\lib\site-packages\twisted\internet\selectreactor.py", line 39, in win32select
r, w, e = select.select(r, w, w, timeout)
builtins.OSError: [WinError 10038] An operation was attempted on something that is not a socket
This is due to passing a Console class to addReader but this fails since
select on Windows cannot handle non-socket file object unlike Unix which accepts
sockets and file objects.
There is likely a further issue where windows-curses has not implemented
resizeterm so would need to use resize_term instead.
Refs: https://docs.python.org/3/library/select.html#select.select
Refs: https://stackoverflow.com/questions/11731175/python-twisted-addreader-works-in-linux-but-not-windows
Refs: zephyrproject-rtos/windows-curses#40
Refs: https://docs.python.org/3/library/curses.html#curses.resize_term
Closes: deluge-torrent#457
Co-authored-by: Calum Lind <calumlind+deluge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Libraries that use Curses expect the
resizetermfunction to be available:I believe that in order to use Tabview with Curses on Windows, the
resizetermfunction will need to be implemented. Based on https://docs.python.org/3/library/curses.html#curses.resize_term it might be slightly different thanresize_term.The text was updated successfully, but these errors were encountered: