From 12df8760a41130e89b9b4240f95db5e81c160fe7 Mon Sep 17 00:00:00 2001 From: Maciej Perkowski Date: Fri, 15 Sep 2023 15:22:15 +0200 Subject: [PATCH] twister: Always change skip to error on integration platforms Before only with --integration such skips were changed to errors. This hinders issues when twister is call with --all flag in CI and new skips on integration platforms are not caught. Then those skips cause errors in other PRs when --integration was used. Signed-off-by: Maciej Perkowski --- scripts/pylib/twister/twisterlib/testplan.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/pylib/twister/twisterlib/testplan.py b/scripts/pylib/twister/twisterlib/testplan.py index 1d9c625b28af898..6f1e89aaf2061cb 100755 --- a/scripts/pylib/twister/twisterlib/testplan.py +++ b/scripts/pylib/twister/twisterlib/testplan.py @@ -1016,8 +1016,8 @@ def _create_build_dir_link(self, links_dir_path, instance): def change_skip_to_error_if_integration(options, instance): - ''' If integration mode is on all skips on integration_platforms are treated as errors.''' - if options.integration and instance.platform.name in instance.testsuite.integration_platforms \ + ''' All skips on integration_platforms are treated as errors.''' + if instance.platform.name in instance.testsuite.integration_platforms \ and "quarantine" not in instance.reason.lower(): # Do not treat this as error if filter type is command line filters = {t['type'] for t in instance.filters}