CODE_DATA_RELOCATION wrongly puts add_compile_definitions() into relocation dictionary

[nordicjm]

Describe the bug
Seeing an issue whereby in a project add_compile_definitions() is used to add a compile definition for the code, upon building however a warning it emitted when doing the code relocation part:

/tmp/aa/zephyr/scripts/build/gen_relocate_app.py:547: UserWarning: File: MIN_SECTOR_COUNT=866 Not found
  warnings.warn("File: "+file_glob+" Not found")

grepping for this yields this in the code relocation file:

./zephyr/relocation_dict.txt:|RAM:COPY:/tmp/aa/zephyr/soc/nxp/imxrt/imxrt5xx/cm33/flash_clock_setup.c|RAM_TEXT:COPY:/tmp/aa/zephyr/drivers/flash/flash_mcux_flexspi_mx25um51345g.c|RAM_TEXT:COPY:/tmp/aa/zephyr/drivers/memc/memc_mcux_flexspi.c|RAM_TEXT:COPY:/tmp/aa/modules/hal/nxp/mcux/mcux-sdk/drivers/flexspi/fsl_flexspi.c;MIN_SECTOR_COUNT=866

I'm not really sure why that is being put there?

To Reproduce
Get mcu-tools/mcuboot#2019
Then build MCUboot using cmake -GNinja -DBOARD=mimxrt595_evk/mimxrt595s/cm33 .. and warning will show

Expected behavior
No warning

Impact
Annoyance in this case, could be more if other definitions start getting put there

Environment (please complete the following information):

• Commit SHA or Version used: c3dd1e8

[nordicjm]

Invalid bug, missed that add_compile_definitions() is the raw cmake function and should not be used, zephyr_compile_definitions() is the correct function