ace: mm: tlb: Ignore unmapping error in driver initalization #78612
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
requested review from
lyakh,
lgirdwood,
abonislawski,
kv2019i,
tmleman,
serhiy-katsyuba-intel and
gbernatxintel
and removed request for
ceolin,
edersondisouza and
dcpleung
gbernatxintel
previously approved these changes
Sep 18, 2024
serhiy-katsyuba-intel
previously approved these changes
Sep 18, 2024
lyakh
reviewed
Sep 18, 2024
tmleman
previously approved these changes
Sep 18, 2024
softwarecki
dismissed stale reviews from tmleman, serhiy-katsyuba-intel, and gbernatxintel
via
f414f7b
softwarecki
force-pushed
the
mm-init-fix
branch
from
cb2c3eb
to
f414f7b
Compare
softwarecki
force-pushed
the
mm-init-fix
branch
from
f414f7b
to
7b88686
Compare
dcpleung
previously approved these changes
Sep 18, 2024
|
@softwarecki you need to re-add your now reverted 311ddf9 too, right? Without it this PR doesn't really work? |
kv2019i
reviewed
Sep 20, 2024
| @@ -478,7 +478,11 @@ static int sys_mm_drv_unmap_region_initial(void *virt_in, size_t size) | |||
|
|
|||
There was a problem hiding this comment.
Typo in title (unmappig->unmapping),plus I think you need to add the reverted commit back to this PR so it fixes the original ace30 problem, right?
softwarecki
changed the title
The sys_mm_drv_unmap_region_initial function is responsible for unmapping all unused virtual memory during tlb driver initialization. Most addresses will not have a mapped page. Ignore the error code indicating unmapped memory that will occur when trying to unmap. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Before unmapping a memory page, the cache is flushed. If the given memory page is not mapped, this operation ends with a cpu exception on the ptl platform. Add check if tlb translation is active before flushing. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
force-pushed
the
mm-init-fix
branch
from
7b88686
to
dcf1f12
Compare
|
Added previously reverted commit from #78227 |
dcpleung
approved these changes
Sep 23, 2024
Thanks for adding a SOF PR. Since it has failed some tests, let me mark this PR "DNM" for now, feel free to remove the label once those failures are fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sys_mm_drv_unmap_region_initial function is responsible for unmapping all unused virtual memory during tlb driver initialization. Most addresses will not have a mapped page. Ignore the error code indicating unmapped memory that will occur when trying to unmap.
Fix for issue detected in: #78479