drivers: adc/wifi: esp32s2/esp32c3: call to adc2_init_code_calibration #79074
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: ADC
zephyrbot
requested review from
anangl,
decsny,
jukkar,
Kludentwo,
krish2718,
LucasTambor,
marekmatej,
raffarost,
rlubos,
sylvioalves and
uLipe
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_espressif
DNM
Update hal to cover latest features and fixes. Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
wmrsouza
force-pushed
the
improvement/adc2_init_code_calibration
branch
from
017d8ea
to
59e279c
Compare
uLipe
reviewed
Sep 26, 2024
drivers/adc/adc_esp32.c
Outdated
| @@ -654,6 +654,12 @@ static int adc_esp32_init(const struct device *dev) | |||
|
|
|||
| adc_hw_calibration(conf->unit); | |||
|
|
|||
| #if CONFIG_SOC_SERIES_ESP32S2 || CONFIG_SOC_SERIES_ESP32C3 | |||
| if (conf->unit == 1) { | |||
There was a problem hiding this comment.
Can we put this hardcoded value behind of a define and explain its reason?
Add call to adc2_init_code_calibration during adc initialization on esp32s2 and esp32c3 Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
Add call to adc2_init_code_calibration during wifi initialization on esp32s2 and esp32c3 Signed-off-by: Marcio Ribeiro <marcio.ribeiro@espressif.com>
wmrsouza
force-pushed
the
improvement/adc2_init_code_calibration
branch
from
59e279c
to
db211d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add call to adc2_init_code_calibration() during adc and wifi initialization on esp32s2 and esp32c3