Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Let cluster config/init bubble up exception groups #120

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jul 31, 2024

Let cluster config/init bubble up exception groups

  • Only skip errors when re-joining

This shows that we have several faults we currently don't detect properly.

@elupus elupus marked this pull request as ready for review August 1, 2024 15:41
@elupus
Copy link
Contributor Author

elupus commented Aug 1, 2024

So i've gotten the tests in line i think. There where several cases where our tests where throwing unexpected exceptions due to unexpected responses on data. This exposes those errors and adds some solutions to them.

What do you guys think?

@elupus
Copy link
Contributor Author

elupus commented Aug 1, 2024

Ps. Some of the fixes should be broken out into separate changes perhaps.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.67%. Comparing base (dfe5ae7) to head (ebc708c).
Report is 1 commits behind head on dev.

Files Patch % Lines
zha/application/gateway.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #120      +/-   ##
==========================================
+ Coverage   95.65%   95.67%   +0.01%     
==========================================
  Files          61       61              
  Lines        9255     9262       +7     
==========================================
+ Hits         8853     8861       +8     
+ Misses        402      401       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puddly
Copy link
Contributor

puddly commented Aug 1, 2024

I think some of the tests are also failing because we are (slowly) migrating away from using lists (and lists-of-lists) to represent command responses to t.Struct subclasses that concurrently support a tuple interface (rsp[0]) in addition to normal attribute lookup (rsp.status). I think the unit tests right now have a lot of places that return lists-of-lists (return [[]]) that bubble up to code that uses attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants