-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Let cluster config/init bubble up exception groups #120
base: dev
Are you sure you want to change the base?
Conversation
Only skip errors when re-joining
We must also make sure that CustomEndpoints get the mocked request.
So i've gotten the tests in line i think. There where several cases where our tests where throwing unexpected exceptions due to unexpected responses on data. This exposes those errors and adds some solutions to them. What do you guys think? |
Ps. Some of the fixes should be broken out into separate changes perhaps. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #120 +/- ##
==========================================
+ Coverage 95.65% 95.67% +0.01%
==========================================
Files 61 61
Lines 9255 9262 +7
==========================================
+ Hits 8853 8861 +8
+ Misses 402 401 -1 ☔ View full report in Codecov by Sentry. |
I think some of the tests are also failing because we are (slowly) migrating away from using lists (and lists-of-lists) to represent command responses to |
Let cluster config/init bubble up exception groups
This shows that we have several faults we currently don't detect properly.