-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensors for Sonoff SWV Smart Water Valve status #189
base: dev
Are you sure you want to change the base?
Conversation
If you run script/setup from the root of the checked out project it will set up a venv for you and also install a commit hook w/ pre-commit so that you can catch the lint errors before committing. if you already have a venv activate it and run |
Pre-commit fixes are now also applied automatically as well when pushed to a PR. So, you can just update your local changes from the branch you pushed to. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #189 +/- ##
==========================================
- Coverage 96.49% 96.46% -0.04%
==========================================
Files 61 61
Lines 9426 9448 +22
==========================================
+ Hits 9096 9114 +18
- Misses 330 334 +4 ☔ View full report in Codecov by Sentry. |
FYI, we merged an initial quirk that defines the custom cluster and attributes: zigpy/zha-device-handlers#3346 |
Proposed change
Adds a valve leak and water supply status binary sensors for export to Home Assistant.
This feature was requested as part of zigpy/zha-device-handlers#3298
Additional information
Testing
I have tested this with my Sonoff SWV-BSP Smart Water Valve.