Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor clean up of code and documentation after @simpleEnum annotation PR #329

Closed
googley42 opened this issue Nov 23, 2023 · 1 comment · Fixed by #338
Closed

minor clean up of code and documentation after @simpleEnum annotation PR #329

googley42 opened this issue Nov 23, 2023 · 1 comment · Fixed by #338

Comments

@googley42
Copy link
Contributor

googley42 commented Nov 23, 2023

the @simpleEnum annotation PR #284 simplified the code and UX for this use case by being more opinionated (removing the choice of encodings)

However we need to:

  1. update the codec annotations doc to a) reflect the new lack of choice for the all object case and to explain the default encoding (we can use same attribute map example for the old annotation). We could mention that internally we use the new annotation and that it it automatically added by the ZIO Schema macro.
  2. remove the new annotation from the code
@googley42 googley42 changed the title minor clean up of test and example code after @simpleEnum annotation PR minor clean up of code and documentation after @simpleEnum annotation PR Nov 23, 2023
@googley42
Copy link
Contributor Author

closed by #338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant