-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure non Scala version specific specs being executed for Scala 3 as well #709
Labels
Comments
987Nabil
changed the title
Move specs to
Ensure non Scala version specific specs being executed for Scala 3 as well
Jun 30, 2024
scala
source folder where possible
/bounty $750 |
💎 $750 bounty • ZIOSteps to solve:
Thank you for contributing to zio/zio-schema! Add a bounty • Share on socials
|
/attempt #709
|
987Nabil
added a commit
to 987Nabil/zio-schema
that referenced
this issue
Aug 5, 2024
💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
987Nabil
added a commit
to 987Nabil/zio-schema
that referenced
this issue
Aug 5, 2024
jdegoes
pushed a commit
that referenced
this issue
Aug 9, 2024
🎉🎈 @987Nabil has been awarded $750! 🎈🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A lot of specs are in the
scala-2
source folders. For example theJsonCodecSpec
.This prevents them from being executed on for Scala 3.
After taking a short look, it seems this will take some time to migrate, since the tests depend on some generators with complex types. These types are evaluated more strict or just different by the Scala 3 compiler and need to be adjusted to make it work across Scala 2 and 3.
@jdegoes I think this might be also a reason why we had some bugs reports, where zio-schema was acting different for Scala 3.
The text was updated successfully, but these errors were encountered: