Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure non Scala version specific specs being executed for Scala 3 as well #709

Closed
987Nabil opened this issue Jun 30, 2024 · 5 comments · Fixed by #721
Closed

Ensure non Scala version specific specs being executed for Scala 3 as well #709

987Nabil opened this issue Jun 30, 2024 · 5 comments · Fixed by #721

Comments

@987Nabil
Copy link
Contributor

A lot of specs are in the scala-2 source folders. For example the JsonCodecSpec.
This prevents them from being executed on for Scala 3.
After taking a short look, it seems this will take some time to migrate, since the tests depend on some generators with complex types. These types are evaluated more strict or just different by the Scala 3 compiler and need to be adjusted to make it work across Scala 2 and 3.

@jdegoes I think this might be also a reason why we had some bugs reports, where zio-schema was acting different for Scala 3.

@987Nabil 987Nabil changed the title Move specs to scala source folder where possible Ensure non Scala version specific specs being executed for Scala 3 as well Jun 30, 2024
@jdegoes
Copy link
Member

jdegoes commented Aug 1, 2024

/bounty $750

Copy link

algora-pbc bot commented Aug 1, 2024

💎 $750 bounty • ZIO

Steps to solve:

  1. Start working: Comment /attempt #709 with your implementation plan
  2. Submit work: Create a pull request including /claim #709 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to zio/zio-schema!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @987Nabil Aug 2, 2024, 2:51:43 PM #721

@987Nabil
Copy link
Contributor Author

987Nabil commented Aug 2, 2024

/attempt #709

Algora profile Completed bounties Tech Active attempts Options
@987Nabil    61 ZIO bounties
+ 1 bounty from 1 project
Scala
﹟1522, ﹟2960
Cancel attempt

Copy link

algora-pbc bot commented Aug 5, 2024

💡 @987Nabil submitted a pull request that claims the bounty. You can visit your bounty board to reward.

987Nabil added a commit to 987Nabil/zio-schema that referenced this issue Aug 5, 2024
Copy link

algora-pbc bot commented Aug 9, 2024

🎉🎈 @987Nabil has been awarded $750! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants