Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-by-one bug in msgpack decoding #743

Closed
tomwadeson opened this issue Sep 16, 2024 · 1 comment · Fixed by #742
Closed

Off-by-one bug in msgpack decoding #743

tomwadeson opened this issue Sep 16, 2024 · 1 comment · Fixed by #742

Comments

@tomwadeson
Copy link
Contributor

A bug is present in MessagePackDecoder, affecting all caseClassNDecoders from 9..22. This results in the following error when decoding:

MalformedFieldWithPath(
        path = Chunk(),
        message = "Different than expected number of fields. Expected 8 but received 9"
      )

Demonstrated and fixed in #742
@tomwadeson
Copy link
Contributor Author

Please let me know if any changes are required on the linked PR.

My team is just kicking off a project that will need to use MessagePack, and this zio-schema integration would suit our needs perfectly. Would it be possible to cut a release with this fix ASAP? 🙏

@987Nabil 987Nabil mentioned this issue Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix off-by-one bug in msgpack decoding tomwadeson/zio-schema
1 participant
@tomwadeson