-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Localization config #55
Comments
We use the outdoor model on Inloc, and all results in the paper are obtained using the publicly available outdoor trained model. Thresholds of 0.1 and 0.2 are both reasonable and can serve as a trade-off between the number of points and precision. We suggest further adjusting the "max_error" and "cell_size" to control the trade-off between track-length and precision. |
Loftr didn't use sub-pixel predictions for db-db pairs by using round() while testing the Visual Localization Work. I wonder to know how do you deal with the EfficientLoftr to keep different keyframe pairs produce variance keypoints for one keyframe. |
We use the merge strategy provided by hloc match_dense.py to handle sub-pixel predictions. |
I am trying to reproduce the implementation on acchen by use the config :
The parameter combinations I tried for the max_marror and cell_size are: "1,1", "2,8", "4,4", "3,8", "4,8", "5,8", "6,8", "7,8", "8,8". It cannot achieve the accuracy of Eloftr. However, the loftr can acieve the accuracy by using the config "2,8". |
Regarding the adjustment of hyperparameters, my suggestion is that cell_size does not necessarily have to be 8; it can be smaller, such as 1, 2, or 4. For max_error, I suggest it should be equal to cell_size or a fraction of cell_size like 1/2, 1/4, etc. Moreover, the results from our paper can be seen on the benchmark. |
Thank you for your answer. I will try it. |
Our results on Aachen and Inloc were obtained by HLoc. |
I use the Hierarchical-Localization to test acchen and inloc dataset. But the reslut is not perform good than Loftr by uisng the same configs. I wonder to know the configs such as the threshold for coarse matching. For Inloc test, do you use the model trained by megadepth?
while I use demo for test, i found in the same configs, the 3D model reconstruction by Eloftr get less point, is it right?
the reconstrction by eloftr:
while the reconstruviont by loftr:
Reconstruction:
by use the same config:
and the coarse matching thresold is 0.2.
The text was updated successfully, but these errors were encountered: