Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify the remaining sound effects constants #234

Open
kemenaran opened this issue May 13, 2020 · 3 comments
Open

Identify the remaining sound effects constants #234

kemenaran opened this issue May 13, 2020 · 3 comments
Labels
audio issue related to the audio code good first issue suited for an easy first contribution

Comments

@kemenaran
Copy link
Collaborator

Many places in the code still have sound effects (sfx, or music tracks) referenced by a numeric value. For instance:

  ld a, $35
  ld [hNextMusicTrack], a

We should ensure that everywhere in the code, these numeric values are replaced by proper constants (found in constants/sfx.asm). For instance:

  ld a, MUSIC_MAMUS_SONG
  ld [hNextMusicTrack], a
@kemenaran kemenaran added good first issue suited for an easy first contribution audio issue related to the audio code labels May 13, 2020
@Vextrove
Copy link
Contributor

I have already done this. I am trying to figure out how to upload an entire src/ folder to github.

@Vextrove
Copy link
Contributor

Oh. I only did it for music files. I have identified all but one music track.
I want to make sure no sound effects are mislabeled like the music used to be. Although some sound effects - particularly those from noiseSFX - are really generic and could be used for two or more entirely different things.

@kemenaran
Copy link
Collaborator Author

kemenaran commented Nov 21, 2020

@Vextrove did a lot of these constants.

Now only remains a handful of unidentified constants in src/constants/sfx.asm. Updating the issue title to reflect this.

@kemenaran kemenaran changed the title Replace all sound numeric IDs by constants Identify the remaining sound effects constants Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio issue related to the audio code good first issue suited for an easy first contribution
Projects
None yet
Development

No branches or pull requests

2 participants