-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support extra (behind the scene...) #463
Comments
Specs for Extra supportVideo Extras are bonus videos related to a resource (a movie or a show). Jellyfin and Plex support video extras. It's time for Kyoo to support them as well! The first challenge with supporting video extras is that there is no standard way of identifying an extra. For example, Plex identifies any file ending with Even though Jellyfin is more flexible than Plex, these two service share a similar point of view regarding extras: no configuration is needed for parsing Extras. This align's with Kyoo's 0 configuration policy. Extra TypesWe should be able to classify extras by type. I think adding new types in the future should be a straight-forward task, so let's not worry about handling all of them straight away. We should be able to handle the following extra types:
In a second time, we should handle all extra types Jellyfin and Plex do. RelationshipsAt least, extras should be related to movies or shows. However, extras can be season specific. For example, we do not want to mix season one's bloopers with season 2. We should discuss whether implementing this from the start is reasonable. As a bonus, Extras could be collection-specific, but I do not have an example of why it would be necessary. It is not possible to have extras without having the related movie or show scanned beforehand. File Architecture (& Configuration)Let's say we have a movie or show (I do not know what we should expect for season-specific extras) NOTE: One should be able to configure the name of the Scanning ProcessWhen the scanner finds files to scan:
Front App LayoutAs a source of inspiration, here is what Extras look like on Plex and Blee: |
Guessing if a file is an extra should be handled by guessit (I think they already have (partial?) support of this). We should not have a magic folder name for this to work. Where should the extra's name be retrieved from? Just the file name? If so, it's way simpler than what I anticipated. Thumbnails would be handled by the transcoder (eagerly via a queue I think), there is plan on handling some files eagerly with #344 (and files from #549 would fall in this category too). For the front side, since kyoo doesn't have a season page I don't know how we could handle seasons extras.
I'm thinking of handling specials like normal episodes/movie if they should be watched w/ the show (aka if absolute number != null). How should we handle other specials (recaps & mini episodes in this case)? |
I don't think that's a good idea. I couldn't find any info about guessit handling this kind of media. Output of guessit on one of those files
See how Unfortunately, since there is no standard for handling extras, I don't see how we could handle them properly without being a little opiniated.
Yeah, doing a bit of parsing by hand is doable. If we design a proper (but as flexible as Jellyfin) way of finding an extra's type through its title, parsing its name is easy.
I think handling specials and extras as a single thing would be a mistake. Mixing them together would not make sense (I wouldn't want a trailer to be next to a recap episode). Moreover, we can rely on guessit to identify specials, but not extras. |
Feature description
No response
The text was updated successfully, but these errors were encountered: