From 3138c4deca81dc42ae40030f33096e4e68ef655b Mon Sep 17 00:00:00 2001 From: "Andrew W. Harn" Date: Wed, 19 Jan 2022 10:54:50 -0500 Subject: [PATCH 1/3] Make the user field on SSH profiles secure Signed-off-by: Andrew W. Harn --- .../imperative.integration.test.ts | 5 +- package-lock.json | 156 +++++++++--------- packages/cli/CHANGELOG.md | 4 + packages/cli/src/imperative.ts | 5 +- packages/zosuss/CHANGELOG.md | 8 + packages/zosuss/src/SshSession.ts | 8 - 6 files changed, 96 insertions(+), 90 deletions(-) diff --git a/__tests__/__integration__/imperative.integration.test.ts b/__tests__/__integration__/imperative.integration.test.ts index 0b9f93acec..b3d42c0247 100644 --- a/__tests__/__integration__/imperative.integration.test.ts +++ b/__tests__/__integration__/imperative.integration.test.ts @@ -103,8 +103,9 @@ describe("imperative create profile", () => { expect(response.stdout.toString()).toContain("Profile created successfully!"); expect(response.stdout.toString()).toContain("FAKEHOST"); expect(response.stdout.toString()).toContain("22"); - expect(response.stdout.toString()).toContain("FAKEUSER"); - expect(response.stdout.toString()).toContain("managed by Zowe CLI"); + expect(response.stdout.toString()).not.toContain("FAKEUSER"); + expect(response.stdout.toString()).toContain("user: managed by Zowe CLI"); + expect(response.stdout.toString()).toContain("password: managed by Zowe CLI"); }); it("should successfully create a profile without username, password, or host", async () => { diff --git a/package-lock.json b/package-lock.json index 438839b098..88c3e2a79c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -62,7 +62,7 @@ }, "__tests__/__packages__/cli-test-utils": { "name": "@zowe/cli-test-utils", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { "@types/js-yaml": "^4.0.0", @@ -24325,22 +24325,22 @@ }, "packages/cli": { "name": "@zowe/cli", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "hasInstallScript": true, "license": "EPL-2.0", "dependencies": { - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "@zowe/perf-timing": "1.0.7", - "@zowe/provisioning-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-console-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-jobs-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-logs-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-tso-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-workflows-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/provisioning-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-console-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-jobs-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-logs-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-tso-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-workflows-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201121428", "find-process": "1.4.7", "get-stdin": "7.0.0", "lodash": "4.17.21", @@ -24356,7 +24356,7 @@ "@types/node": "^12.12.24", "@types/tar": "6.1.1", "@types/which": "2.0.1", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", "comment-json": "^4.1.0", "eslint": "^7.32.0", "js-yaml": "^3.13.1", @@ -24427,7 +24427,7 @@ }, "packages/core": { "name": "@zowe/core-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { "comment-json": "4.1.0", @@ -24435,7 +24435,7 @@ }, "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "chalk": "^4.1.0", "eslint": "^7.32.0", @@ -24450,7 +24450,7 @@ }, "packages/provisioning": { "name": "@zowe/provisioning-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { "js-yaml": "3.14.1" @@ -24458,8 +24458,8 @@ "devDependencies": { "@types/js-yaml": "^3.12.5", "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -24480,15 +24480,15 @@ }, "packages/workflows": { "name": "@zowe/zos-workflows-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { - "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201111811" + "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201121428" }, "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -24503,12 +24503,12 @@ }, "packages/zosconsole": { "name": "@zowe/zos-console-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -24523,17 +24523,17 @@ }, "packages/zosfiles": { "name": "@zowe/zos-files-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { "minimatch": "3.0.4" }, "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", - "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201121428", "eslint": "^7.32.0", "madge": "^4.0.1", "rimraf": "^2.6.3", @@ -24547,15 +24547,15 @@ }, "packages/zosjobs": { "name": "@zowe/zos-jobs-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { - "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201111811" + "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201121428" }, "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -24570,12 +24570,12 @@ }, "packages/zoslogs": { "name": "@zowe/zos-logs-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -24590,12 +24590,12 @@ }, "packages/zosmf": { "name": "@zowe/zosmf-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -24610,15 +24610,15 @@ }, "packages/zostso": { "name": "@zowe/zos-tso-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { - "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201111811" + "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201121428" }, "devDependencies": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -24633,7 +24633,7 @@ }, "packages/zosuss": { "name": "@zowe/zos-uss-for-zowe-sdk", - "version": "7.0.0-next.202201111811", + "version": "7.0.0-next.202201121428", "license": "EPL-2.0", "dependencies": { "ssh2": "1.4.0" @@ -24641,7 +24641,7 @@ "devDependencies": { "@types/node": "^12.12.24", "@types/ssh2": "^0.5.44", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -28608,19 +28608,19 @@ "@types/node": "^12.12.24", "@types/tar": "6.1.1", "@types/which": "2.0.1", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "@zowe/perf-timing": "1.0.7", - "@zowe/provisioning-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-console-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-jobs-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-logs-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-tso-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zos-workflows-for-zowe-sdk": "7.0.0-next.202201111811", - "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/provisioning-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-console-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-jobs-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-logs-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-tso-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zos-workflows-for-zowe-sdk": "7.0.0-next.202201121428", + "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201121428", "comment-json": "^4.1.0", "eslint": "^7.32.0", "find-process": "1.4.7", @@ -28752,7 +28752,7 @@ "version": "file:packages/core", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "chalk": "^4.1.0", "comment-json": "4.1.0", @@ -28900,8 +28900,8 @@ "requires": { "@types/js-yaml": "^3.12.5", "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "js-yaml": "3.14.1", @@ -28923,8 +28923,8 @@ "version": "file:packages/zosconsole", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -28937,10 +28937,10 @@ "version": "file:packages/zosfiles", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", - "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/zos-uss-for-zowe-sdk": "7.0.0-next.202201121428", "eslint": "^7.32.0", "madge": "^4.0.1", "minimatch": "3.0.4", @@ -28953,10 +28953,10 @@ "version": "file:packages/zosjobs", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", - "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201121428", "eslint": "^7.32.0", "madge": "^4.0.1", "rimraf": "^2.6.3", @@ -28968,8 +28968,8 @@ "version": "file:packages/zoslogs", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -28982,10 +28982,10 @@ "version": "file:packages/zostso", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", - "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/zosmf-for-zowe-sdk": "7.0.0-next.202201121428", "eslint": "^7.32.0", "madge": "^4.0.1", "rimraf": "^2.6.3", @@ -28998,7 +28998,7 @@ "requires": { "@types/node": "^12.12.24", "@types/ssh2": "^0.5.44", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", @@ -29012,10 +29012,10 @@ "version": "file:packages/workflows", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", - "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/zos-files-for-zowe-sdk": "7.0.0-next.202201121428", "eslint": "^7.32.0", "madge": "^4.0.1", "rimraf": "^2.6.3", @@ -29027,8 +29027,8 @@ "version": "file:packages/zosmf", "requires": { "@types/node": "^12.12.24", - "@zowe/cli-test-utils": "7.0.0-next.202201111811", - "@zowe/core-for-zowe-sdk": "7.0.0-next.202201111811", + "@zowe/cli-test-utils": "7.0.0-next.202201121428", + "@zowe/core-for-zowe-sdk": "7.0.0-next.202201121428", "@zowe/imperative": "5.0.0-next.202201111920", "eslint": "^7.32.0", "madge": "^4.0.1", diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md index c87660c986..626594343a 100644 --- a/packages/cli/CHANGELOG.md +++ b/packages/cli/CHANGELOG.md @@ -2,6 +2,10 @@ All notable changes to the Zowe CLI package will be documented in this file. +## Recent Changes + +- **BREAKING** Enhancement: Make the `user` field on SSH profiles secure. [#682](https://github.com/zowe/zowe-cli/issues/682) + ## `7.0.0-next.202201121428` - BugFix: Set executable attribute on zowe executable file on Linux and Mac. diff --git a/packages/cli/src/imperative.ts b/packages/cli/src/imperative.ts index 1ec30a5862..789c5a0028 100644 --- a/packages/cli/src/imperative.ts +++ b/packages/cli/src/imperative.ts @@ -379,7 +379,7 @@ const config: IImperativeConfig = { properties: { host: { type: "string", - optionDefinition: SshSession.SSH_OPTION_HOST_PROFILE, + optionDefinition: SshSession.SSH_OPTION_HOST, includeInTemplate: true }, port: { @@ -389,7 +389,8 @@ const config: IImperativeConfig = { }, user: { type: "string", - optionDefinition: SshSession.SSH_OPTION_USER_PROFILE + secure: true, + optionDefinition: SshSession.SSH_OPTION_USER }, password: { type: "string", diff --git a/packages/zosuss/CHANGELOG.md b/packages/zosuss/CHANGELOG.md index 9daaa9e09e..30459308a2 100644 --- a/packages/zosuss/CHANGELOG.md +++ b/packages/zosuss/CHANGELOG.md @@ -2,6 +2,14 @@ All notable changes to the Zowe z/OS USS SDK package will be documented in this file. +## Recent Changes + +- **Breaking**: Removed the following command option definitions: + - SSH_OPTION_HOST_PROFILE + - Replace with SSH_OPTION_HOST + - SSH_OPTION_USER_PROFILE + - Replace with SSH_OPTION_USER + ## `7.0.0-next.202106071827` - **Breaking**: Removed the following [deprecated API functions](https://github.com/zowe/zowe-cli/pull/1022): diff --git a/packages/zosuss/src/SshSession.ts b/packages/zosuss/src/SshSession.ts index eed37052e8..2b779915d3 100644 --- a/packages/zosuss/src/SshSession.ts +++ b/packages/zosuss/src/SshSession.ts @@ -53,10 +53,6 @@ export class SshSession { required: false, group: SshSession.SSH_CONNECTION_OPTION_GROUP }; - public static SSH_OPTION_HOST_PROFILE: ICommandOptionDefinition = { - ...SshSession.SSH_OPTION_HOST, - required: false - }; /** * Option used in profile creation and commands for port for z/OS SSH @@ -81,10 +77,6 @@ export class SshSession { required: false, group: SshSession.SSH_CONNECTION_OPTION_GROUP }; - public static SSH_OPTION_USER_PROFILE: ICommandOptionDefinition = { - ...SshSession.SSH_OPTION_USER, - required: false - }; /** * Option used in profile creation and commands for password/passphrase for z/OS SSH From 72f624a399a7a77f729fd2a4b80284c8f21b8caa Mon Sep 17 00:00:00 2001 From: "Andrew W. Harn" Date: Wed, 19 Jan 2022 11:47:43 -0500 Subject: [PATCH 2/3] Deprecate instead of remove Signed-off-by: Andrew W. Harn --- packages/zosuss/CHANGELOG.md | 2 +- packages/zosuss/src/SshSession.ts | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/packages/zosuss/CHANGELOG.md b/packages/zosuss/CHANGELOG.md index 30459308a2..7336861a00 100644 --- a/packages/zosuss/CHANGELOG.md +++ b/packages/zosuss/CHANGELOG.md @@ -4,7 +4,7 @@ All notable changes to the Zowe z/OS USS SDK package will be documented in this ## Recent Changes -- **Breaking**: Removed the following command option definitions: +- Documentation: Deprecated the following command option definitions: - SSH_OPTION_HOST_PROFILE - Replace with SSH_OPTION_HOST - SSH_OPTION_USER_PROFILE diff --git a/packages/zosuss/src/SshSession.ts b/packages/zosuss/src/SshSession.ts index 2b779915d3..2c83b30923 100644 --- a/packages/zosuss/src/SshSession.ts +++ b/packages/zosuss/src/SshSession.ts @@ -54,6 +54,11 @@ export class SshSession { group: SshSession.SSH_CONNECTION_OPTION_GROUP }; + /** + * @deprecated Use SSH_OPTION_HOST + */ + public static SSH_OPTION_HOST_PROFILE: ICommandOptionDefinition = this.SSH_OPTION_HOST; + /** * Option used in profile creation and commands for port for z/OS SSH */ @@ -78,6 +83,11 @@ export class SshSession { group: SshSession.SSH_CONNECTION_OPTION_GROUP }; + /** + * @deprecated Use SSH_OPTION_USER + */ + public static SSH_OPTION_USER_PROFILE: ICommandOptionDefinition = this.SSH_OPTION_USER; + /** * Option used in profile creation and commands for password/passphrase for z/OS SSH */ From 96cde271ec8e49df1e4b67fe3d98cbf4ec24312a Mon Sep 17 00:00:00 2001 From: "Andrew W. Harn" Date: Wed, 19 Jan 2022 11:55:52 -0500 Subject: [PATCH 3/3] Don't use 'this' Signed-off-by: Andrew W. Harn --- packages/zosuss/src/SshSession.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/zosuss/src/SshSession.ts b/packages/zosuss/src/SshSession.ts index 2c83b30923..3579651ce2 100644 --- a/packages/zosuss/src/SshSession.ts +++ b/packages/zosuss/src/SshSession.ts @@ -57,7 +57,7 @@ export class SshSession { /** * @deprecated Use SSH_OPTION_HOST */ - public static SSH_OPTION_HOST_PROFILE: ICommandOptionDefinition = this.SSH_OPTION_HOST; + public static SSH_OPTION_HOST_PROFILE: ICommandOptionDefinition = SshSession.SSH_OPTION_HOST; /** * Option used in profile creation and commands for port for z/OS SSH @@ -86,7 +86,7 @@ export class SshSession { /** * @deprecated Use SSH_OPTION_USER */ - public static SSH_OPTION_USER_PROFILE: ICommandOptionDefinition = this.SSH_OPTION_USER; + public static SSH_OPTION_USER_PROFILE: ICommandOptionDefinition = SshSession.SSH_OPTION_USER; /** * Option used in profile creation and commands for password/passphrase for z/OS SSH