Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate constant for PLUGIN_USING_CONFIG #2341

Open
t1m0thyj opened this issue Nov 1, 2024 · 2 comments
Open

Deprecate constant for PLUGIN_USING_CONFIG #2341

t1m0thyj opened this issue Nov 1, 2024 · 2 comments
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have v4 Prospective changes for v4

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Nov 1, 2024

Since team config is always used after the removal of V1 profiles, this constant could be deprecated in V3 and removed in V4.

public readonly PLUGIN_USING_CONFIG: boolean;

this.PLUGIN_USING_CONFIG = ImperativeConfig.instance.config?.exists;

if (this.PLUGIN_USING_CONFIG) {
this.PLUGIN_CONFIG.paths.forEach((path: string) => {
const dir = dirname(path);
modPaths.push(join(dir, process.platform !== "win32" ? "lib" : "", "node_modules"));
});
}

@t1m0thyj t1m0thyj added bug Something isn't working new The issue wasn't triaged yet labels Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Thank you for creating a bug report.
We will investigate the bug and evaluate its impact on the product.
If you haven't already, please ensure you have provided steps to reproduce the bug and as much context as possible.

@t1m0thyj t1m0thyj added enhancement New feature or request and removed bug Something isn't working labels Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Thank you for raising this enhancement request.
The community has 90 days to vote on it.
If the enhancement receives at least 5 upvotes, it is added to our development backlog.
If it receives fewer votes, the issue is closed.

@JTonda JTonda added priority-low Legit issue but cosmetic or nice-to-have and removed new The issue wasn't triaged yet labels Nov 4, 2024
@zFernand0 zFernand0 added the v4 Prospective changes for v4 label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have v4 Prospective changes for v4
Projects
Status: Low Priority
Development

No branches or pull requests

3 participants