Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download API JSDoc #50

Closed
JTonda opened this issue Oct 9, 2018 · 4 comments
Closed

Download API JSDoc #50

JTonda opened this issue Oct 9, 2018 · 4 comments
Milestone

Comments

@JTonda
Copy link

JTonda commented Oct 9, 2018

From @dkelosky on July 13, 2018 19:31

Download.dataset returns a IZosmfFilesResponse object which references "commands". At the API usage, is commandResponse actually the data set content?
image

Copied from original issue: gizafoundation/brightside#153

@JTonda
Copy link
Author

JTonda commented Oct 9, 2018

From @zFernand0 on August 29, 2018 12:12

commandResponse is basically a success message that gets forwarded to the handler, which doesn't seem very useful for API usage only.
On the other hand, apiResponse is the guy that contains the content of the downloaded data set.

Two possible solutions for this misunderstanding, let's vote (:+1: or :-1:)
(If you have a new solution please feel free to add it)

@JTonda
Copy link
Author

JTonda commented Oct 9, 2018

From @zFernand0 on August 29, 2018 12:13

  • Add more explicit JSDoc comments. (This is probably the quickest solution)

@JTonda
Copy link
Author

JTonda commented Oct 9, 2018

From @zFernand0 on August 29, 2018 12:13

  • Remove commandResponse all together from IZosmFilesResponse, and let the command handlers format their own messages (if needed) since API users wouldn't really care about the command messages.

@JTonda JTonda added this to the Backlog milestone Oct 11, 2018
@MikeBauerCA
Copy link
Contributor

Closing in favor of #865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants