Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WTO messages are broken in ZIS v2.11.0 #406

Closed
ifakhrutdinov opened this issue Oct 10, 2023 · 2 comments
Closed

WTO messages are broken in ZIS v2.11.0 #406

ifakhrutdinov opened this issue Oct 10, 2023 · 2 comments
Labels
bug Something isn't working new not yet triaged priority-high An important issue that should be at least considered for the next PI, ideally within this one, if t severity-high A bug for which there may be workaround but limits the usage of the Zowe for major use cases

Comments

@ifakhrutdinov
Copy link
Contributor

ifakhrutdinov commented Oct 10, 2023

Describe the bug

Steps to Reproduce

  1. Start ZIS
  2. Look for the WTO message ZWES0001I in JESMSGLG
  3. Formatting is completely broken
ZWES0001I ZSS Cross-Memory Server starting, version is 1004045136.1004045136.1004045128+-957029695

Expected behavior

The message should look like this

ZWES0001I ZSS Cross-Memory Server starting, version is 2.10.0+20230712

This affects all the plugins which use wtoPrintf (both statically and via dynamic linkage).

Logs

Describe your environment

Zowe v2.11.0

Additional context
Likely caused by #391

@ifakhrutdinov ifakhrutdinov added bug Something isn't working new not yet triaged severity-high A bug for which there may be workaround but limits the usage of the Zowe for major use cases labels Oct 10, 2023
@ifakhrutdinov
Copy link
Contributor Author

@DivergentEuropeans

  • Based on the way how it's used, I think the wtoPrintf3 function should have used different arguments
- void wtoPrintf3(const char *formatString, ...);
+ void wtoPrintf3(const char *formatString, va_list arg);
  • How much did you test the changes?

CC: @JoeNemo , @1000TurquoisePogs

@ifakhrutdinov ifakhrutdinov changed the title WTO messages are broken in ZIS WTO messages are broken in ZIS v2.11.0 Oct 10, 2023
@ifakhrutdinov ifakhrutdinov added the priority-high An important issue that should be at least considered for the next PI, ideally within this one, if t label Oct 10, 2023
@DivergentEuropeans
Copy link
Member

@ifakhrutdinov Is it broken for ZSS too?

I tested for ZSS and it was working in the beginning. It's possible it broke during the code review refactor, either for ZIS or both. I probably checked for log to appear but didn't scroll through the args in the final days of testing. Thanks @ifakhrutdinov , good catch. We have another important priority I'll be working on next sprint when I come back from PTO so we'll either assign this to myself or to someone else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new not yet triaged priority-high An important issue that should be at least considered for the next PI, ideally within this one, if t severity-high A bug for which there may be workaround but limits the usage of the Zowe for major use cases
Projects
None yet
Development

No branches or pull requests

2 participants