Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out some logic into generic functions for FileSystemProviders #3099

Open
traeok opened this issue Sep 6, 2024 · 0 comments
Open

Pull out some logic into generic functions for FileSystemProviders #3099

traeok opened this issue Sep 6, 2024 · 0 comments
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have

Comments

@traeok
Copy link
Member

traeok commented Sep 6, 2024

Is your feature request related to a problem? Please describe.

While the logic is similar between Data Sets and USS for some of the filesystem functions, there are nuances that make it hard to avoid code duplication. That said, it would still be nice to pull some logic into common functions so it can be used across both filesystem implementations.

Describe the solution you'd like

Investigate readFile, writeFile and readDirectory functions for both filesystems and pull out common code into generic functions where possible.

Describe alternatives you've considered

We can keep the code as-is, but if we can consolidate more shared code, it will make it easier to maintain moving forward.

@traeok traeok added enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low Legit issue but cosmetic or nice-to-have
Projects
Status: Low Priority
Development

No branches or pull requests

1 participant