Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate-to-ogc branch #14

Open
hernanmd opened this issue Dec 1, 2021 · 1 comment
Open

migrate-to-ogc branch #14

hernanmd opened this issue Dec 1, 2021 · 1 comment

Comments

@hernanmd
Copy link
Contributor

hernanmd commented Dec 1, 2021

Laurine told me there is a branch named migrate-to-ogc which can be used with the OGC-Pharo package.
For example:

GeoJSONReader fromString: GeoJSONExamples barsLilleGJ.

All is needed is to load 'OGC-Spheric' and 'OGC-Spheric-Tests' before.
And GeoJSON-Examples after loading GeoJSON.

So far I checked and it seems this branch add new classes prefixed with GJ like GJAddress.
Is the idea to migrate all source of this branch to OGC project?

@noha
Copy link
Member

noha commented Dec 7, 2021

The GJAddress class was added quite some time ago. It is in the main branch. The migrate-to-ogc branch has yet not been merged because I don't find time and there are some adjustments to do like adjusting GJAddress and voyage/mongo extensions. So it needs to be polished in order to make it the default.
But yes I planned to do the move to OGC so we start a common ground for geo tools. I switched my KML reader already because now I can read KML and save as GeoJSON. My biggest problem so far is that OGCPoint is rather heavy with its 4 instVars and that makes GeoJSON probably bloated as well. But also no time to think if that can be done differently by choosing the model or making OGC more modular.
What do you think? I pushed Laurine to also do an inspector morph. So we can actually have good tools to read from the net and show directly on a map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants