divert calls to oneDNN's gemm_api into ACL #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Transformer models, Tensorflow calls the MklMatMulOp layer which requires a BLAS SGEMM interface not supported by the Arm Compute Library (See #168). As a result, these layers to fall into the sub-optimal oneDNN's reference gemm_api kernels.
This patch directs calls to MklMatMulOp into BatchMatMulMkl for aarch64. Hence, avoiding the need for the BLAS SGEMM interface and allowing the ACL matmul kernels to be used instead of gemm_api.