Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Website Enhancement #206

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

yashksaini-coder
Copy link
Contributor

@yashksaini-coder yashksaini-coder commented Nov 7, 2024

Summary

I have update the main logo and also fixed some routing bugs.

how-it-works-bugfix.webm

@this-is-yaash kindly review this PR, and assign it to me with proper labels

@iamyaash
Copy link
Collaborator

iamyaash commented Nov 8, 2024

@yashksaini-coder please share the screenshot of your changes!

@yashksaini-coder
Copy link
Contributor Author

@yashksaini-coder please share the screenshot of your changes!

image

Copy link
Collaborator

@iamyaash iamyaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@iamyaash iamyaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts!

@iamyaash iamyaash added good first issue Good for newcomers gssoc-ext Issues labelled only for GSSoC'24 Extended Edition hacktoberfest-accepted hacktoberfest 2024 level2 Issues that are medium difficulty to fix labels Nov 8, 2024
@iamyaash iamyaash merged commit 48e4e01 into AmateursLeague:main Nov 8, 2024
1 check failed
@iamyaash
Copy link
Collaborator

iamyaash commented Nov 8, 2024

@yashksaini-coder increased lvl due to pointing out routing error in the site!
(Which has gone unnoticed!)
good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers gssoc-ext Issues labelled only for GSSoC'24 Extended Edition hacktoberfest-accepted hacktoberfest 2024 level2 Issues that are medium difficulty to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants