Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving the dark mode functionality on home page #871

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

charu1110
Copy link

@charu1110 charu1110 commented Jan 13, 2025

Description

Made certain changes to imporve the dark mode functionality on home page

Related Issues

Type of PR

  • ()

Screenshots / videos (if applicable)

image
image
image
image
image

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

i have added the dark mode functionality to many different pages on this website..

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @charu1110! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work!

Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for vintagevibe ready!

Name Link
🔨 Latest commit 599e19a
🔍 Latest deploy log https://app.netlify.com/sites/vintagevibe/deploys/678670ea288fd9000873148d
😎 Deploy Preview https://deploy-preview-871--vintagevibe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

@charu1110 make sure feature is added to whole website , so that i can assign u Advanced label

@charu1110
Copy link
Author

@Anjaliavv51 can u please check(reveiw) it again ??

@Anjaliavv51
Copy link
Owner

@charu1110 please change the background image into dark mode color , if possible

@charu1110
Copy link
Author

@Anjaliavv51 i think the image is already good fit for dark mode !?

@charu1110
Copy link
Author

@Anjaliavv51 i have changed the background image for dark mode . please reveiw it once .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[bug]: Improving the dark mode functionality on home page .
2 participants