yml update2 (#88)

pre-install global package spfx-fast-serve in node 18 (any os) as a workaround removed sortPackage tmp logging
BassemNKhalil · Nov 17, 2023 · 33bd738 · 33bd738 · github-actions · Nov 17, 2023
1 parent f64ffd8
commit 33bd738
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/dispatch.yml b/.github/workflows/dispatch.yml
@@ -24,5 +24,6 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.version }}
-      - run: npm config get cache
+      - run: npm i -g spfx-fast-serve
+        if: ${{ matrix.version == 18  }}
       - run: npm cit
diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml
@@ -25,8 +25,9 @@ jobs:
         with:
           node-version: ${{ matrix.version }}
           cache: "npm"
-      - run: npm ci
-      - run: npm test
+      - run: npm i -g spfx-fast-serve
+        if: ${{ matrix.version == 18  }}
+      - run: npm cit
   coverage-report:
     uses: ./.github/workflows/jest_coverage_report.yml
     needs: run-tests

diff --git a/Tests/e2e/Commands/sortPackage.test.js b/Tests/e2e/Commands/sortPackage.test.js
@@ -8,10 +8,8 @@ const packageJSON_filePath = join(wpFolderPath, "package.json");
 
 beforeAll(() => {
   packageJSON_beforeChanges = fs.readFileSync(packageJSON_filePath, "utf8");
-  console.log(`packageJSON_beforeChanges: ${packageJSON_beforeChanges}`);
   sortPackageCommand.sortPackage(packageJSON_filePath);
   packageJSON_afterChanges = fs.readFileSync(packageJSON_filePath, "utf8");
-  console.log(`packageJSON_afterChanges: ${packageJSON_afterChanges}`);
 });
 
 test("sortPackage: Package.json file changed", () => {
St.^❔	Category	Percentage	Covered / Total
🟢	Statements	100%	124/124
🟢	Branches	100%	10/10
🟢	Functions	100%	13/13
🟢	Lines	100%	124/124