Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Compact mode #299

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add a Compact mode #299

wants to merge 7 commits into from

Conversation

Mr-Pine
Copy link

@Mr-Pine Mr-Pine commented Nov 4, 2023

This PR adds a compact mode (by default toggleable with c).
Compact mode changes the following:

  • No labels on the AspectFrames
  • No wide handles
  • No menubar
  • Smaller font in the bottom bar

This is especially useful for (small) laptop screens

@Cimbali
Copy link
Owner

Cimbali commented Nov 5, 2023

Thanks, this looks interesting. Could you provide before/after screenshots so I can have an idea what this looks like on your setup with your screen resolution etc.? In particular I’m wondering if just changing font sizes would achieve roughly the same effect

@Mr-Pine
Copy link
Author

Mr-Pine commented Nov 5, 2023

Sure, here's a comparison:
image

vs

image

@Cimbali
Copy link
Owner

Cimbali commented Nov 7, 2023

I see, you’re gaining 11% on the next/current slides and .9% on the notes, so it’s more of a feature for people who don’t like inefficiency than an actual sizeable increase in fonts. The main drawback I see would be people accidentally pressing the button, and being lost because there’s no obvious way to go back.

I’d like to suggest 2 main changes:

  1. compact mode and hiding the menu bar should be 2 separated checkboxes/actions, with a more universal and harder to use shortcut for hiding the menu bar (ctrl+m or ctrl+shift+m should do).
  2. try and change the margins through css instead of changing all margins manually on widgets.
    css_provider.load_from_data() replaces all the existing data so we’d need to change the bottom bar font size and margins in one call.

@Cimbali Cimbali force-pushed the main branch 4 times, most recently from 8451de3 to caef6fc Compare December 15, 2023 00:31
@Cimbali
Copy link
Owner

Cimbali commented Mar 2, 2024

@Mr-Pine are you interested in adding those changes to the PR? I may find the time myself at some point but likely not soon.

@Mr-Pine
Copy link
Author

Mr-Pine commented Mar 2, 2024

Currently I sadly don't have the time to work on this :(

@Cimbali
Copy link
Owner

Cimbali commented Mar 2, 2024

No worries, thanks for letting me know.

@Cimbali
Copy link
Owner

Cimbali commented Apr 17, 2024

I’ve split the Presentation menu in 2 menus as it was starting to get quite large:

image
image

Not 100% sure about the element’s positions yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants