[pull] main from actions:main #1

pull · 2022-06-29T16:12:53Z

See Commits and Changes for more details.

Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

commit-lint · 2022-07-01T08:43:50Z

Contributors

erik-bershel, ilia-shipitsin, vpolikarpov-akvelon, mikhailkoliada, github-actions[bot], Alexey-Ayupov

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

viezly · 2022-07-01T08:44:24Z

This pull request is split into 69 parts for easier review.
👀 Review pull request on Viezly

Changed files are located in these folders:

.github
.github/ISSUE_TEMPLATE
.github/workflows
.vscode
/
docs
helpers
helpers/software-report-base
images.CI
images.CI/macos
images/linux
images/macos
images/ubuntu
images/win
images/windows

sonatype-lift · 2022-08-19T13:18:13Z

images/linux/scripts/installers/google-chrome.sh

+    FIRST_PART_OF_PREVIOUS_REVISION=$(expr $FIRST_PART_OF_REVISION - 1)
+    URL="https://www.googleapis.com/storage/v1/b/chromium-browser-snapshots/o?delimiter=/&prefix=Linux_x64"
+    # Revision can include a hash instead of a number. Need to filter it out https://github.com/actions/runner-images/issues/5256
+    VERSIONS=$((curl -s $URL/${FIRST_PART_OF_REVISION} | jq -r '.prefixes[]' && curl -s $URL/${FIRST_PART_OF_PREVIOUS_REVISION} | jq -r '.prefixes[]') | grep -E "Linux_x64\/[0-9]+\/"| cut -d "/" -f 2 | sort --version-sort)


SC1102: Shells disambiguate $(( differently or not at all. For $(command substitution), add space after $( . For $((arithmetics)), fix parsing errors.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:14Z

images/linux/scripts/installers/java-tools.sh

+
+    JAVA_TOOLCACHE_PATH="${AGENT_TOOLSDIRECTORY}/Java_${VENDOR_NAME}_jdk"
+
+    fullJavaVersion=$(cat "${javaVersionPath}/release" | grep "^SEMANTIC" | cut -d "=" -f 2 | tr -d "\"" | tr "+" "-")


SC2002: Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:16Z

images/linux/scripts/installers/google-chrome.sh

+    # Take the first part of the revision variable to search not only for a specific version,
+    # but also for similar ones, so that we can get a previous one if the required revision is not found
+    FIRST_PART_OF_REVISION=${REVISION:0:${#REVISION}/2}
+    FIRST_PART_OF_PREVIOUS_REVISION=$(expr $FIRST_PART_OF_REVISION - 1)


SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]].

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:17Z

images/macos/provision/core/ruby.sh

-fi
+brew_smart_install "ruby@${DEFAULT_RUBY_VERSION}"
+export PATH=/usr/local/opt/ruby@${DEFAULT_RUBY_VERSION}/bin:$PATH
+GEM_PATH=`gem env|awk '/EXECUTABLE DIRECTORY/ {print $4}'`


SC2006: Use $(...) notation instead of legacy backticks ....

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:19Z

images/linux/scripts/installers/homebrew.sh

+    brew install $package
+    # create symlinks for zstd in /usr/local/bin
+    if [[ $package == "zstd" ]]; then
+        find $(brew --prefix)/bin -name *zstd* -exec sudo sh -c 'ln -s {} /usr/local/bin/$(basename {})' ';'


SC2035: Use ./glob or -- glob so names with dashes won't become options.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:20Z

images/macos/provision/core/golang.sh

+brew_smart_install "go@${DEFAULT_GO_VERSION}"
+
+# Create symlinks to preserve backward compatibility. Symlinks are not created when non-latest go is being installed
+ln -sf $(brew --prefix go@${DEFAULT_GO_VERSION})/bin/* /usr/local/bin/


SC2046: Quote this to prevent word splitting.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:21Z

images/linux/scripts/installers/homebrew.sh

+    brew install $package
+    # create symlinks for zstd in /usr/local/bin
+    if [[ $package == "zstd" ]]; then
+        find $(brew --prefix)/bin -name *zstd* -exec sudo sh -c 'ln -s {} /usr/local/bin/$(basename {})' ';'


SC2061: Quote the parameter to -name so the shell won't interpret it.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:22Z

images/macos/provision/core/android-toolsets.sh

 ANDROID_NDK_LATEST_HOME=$ANDROID_HOME/ndk/$ndkLatest
+# ANDROID_NDK, ANDROID_NDK_HOME, and ANDROID_NDK_ROOT variables should be set as many customer builds depend on them https://github.com/actions/runner-images/issues/5879
+echo "export ANDROID_NDK=$ANDROID_NDK_HOME" >> "${HOME}/.bashrc"


SC2129: Consider using { cmd1; cmd2; } >> file instead of individual redirects.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:24Z

images/linux/scripts/base/limits.sh

+echo 'DefaultLimitSTACK=16M:infinity' >> /etc/systemd/system.conf
+
+# Raise Number of File Descriptors
+echo '* soft nofile 65536' >> /etc/security/limits.conf


SC2129: Consider using { cmd1; cmd2; } >> file instead of individual redirects.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:25Z

images/macos/provision/assets/select-xamarin-sdk-v2.sh

+  local countDigit=$(echo "${version}" | grep -o "\." | grep -c "\.")
+
+  if [[ countDigit -gt 1 ]]; then
+    echo "[WARNING] It is not recommended to specify the exact framework version because your build can be broken with the next patch update. Consider using "major.minor" only format."


SC2140: Word is of the form "A"B"C" (B indicated). Did you mean "ABC" or "A"B"C"?

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:27Z

images/linux/scripts/installers/docker-moby.sh

@@ -45,4 +46,10 @@ done
 # stored from earlier.
 docker logout

+# Install amazon-ecr-credential-helper
+aws_latest_release_url="https://api.github.com/repos/awslabs/amazon-ecr-credential-helper/releases/latest"
+aws_helper_url=$(curl "${authString[@]}" -sL $aws_latest_release_url | jq -r '.body' | awk -F'[()]' '/linux-amd64/ {print $2}')


SC2154: authString is referenced but not assigned.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:28Z

images/linux/scripts/installers/homebrew.sh

+    brew install $package
+    # create symlinks for zstd in /usr/local/bin
+    if [[ $package == "zstd" ]]; then
+        find $(brew --prefix)/bin -name *zstd* -exec sudo sh -c 'ln -s {} /usr/local/bin/$(basename {})' ';'


SC2156: Injecting filenames is fragile and insecure. Use parameters.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:29Z

images/macos/provision/core/llvm.sh

@@ -0,0 +1,8 @@
+#!/bin/bash -e -o pipefail
+source ~/utils/utils.sh


💬 5 similar findings have been found in this PR

SC1090: ShellCheck can't follow non-constant source. Use a directive to specify location.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/core/graalvm.sh 2

images/macos/provision/core/golang.sh 2

images/macos/provision/core/codeql-bundle.sh 2

images/macos/provision/configuration/configure-tccdb-macos.sh 5

images/macos/provision/configuration/configure-machine.sh 3

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:31Z

images/linux/scripts/installers/yq.sh

+#!/bin/bash -e
+
+# Source the helpers for use with the script
+source $HELPER_SCRIPTS/install.sh


💬 35 similar findings have been found in this PR

SC1091: Not following: ./install.sh was not specified as input (see shellcheck -x).

Expand here to view all instances of this finding

File Path Line Number

images/linux/scripts/installers/terraform.sh 7

images/linux/scripts/installers/swift.sh 8

images/linux/scripts/installers/sqlpackage.sh 8

images/linux/scripts/installers/sqlpackage.sh 9

images/linux/scripts/installers/selenium.sh 8

images/linux/scripts/installers/sbt.sh 7

images/linux/scripts/installers/rust.sh 9

images/linux/scripts/installers/ruby.sh 7

images/linux/scripts/installers/postgresql.sh 8

images/linux/scripts/installers/postgresql.sh 9

Showing 10 of 35 findings. Visit the Lift Web Console to see all.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:32Z

images/macos/provision/bootstrap-provisioner/setAutoLogin.sh

+    if [ ${#thisStringHex_array[@]} -eq 11 ]; then
+        local padding=1
+    elif [ $r -gt 0 ]; then
+        local padding=$(( 11 - $r ))


💬 2 similar findings have been found in this PR

SC2004: $/${} is unnecessary on arithmetic variables.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/bootstrap-provisioner/setAutoLogin.sh 35

images/macos/provision/bootstrap-provisioner/setAutoLogin.sh 37

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:34Z

images/macos/provision/core/ruby.sh

+export PATH=/usr/local/opt/ruby@${DEFAULT_RUBY_VERSION}/bin:$PATH
+GEM_PATH=`gem env|awk '/EXECUTABLE DIRECTORY/ {print $4}'`
+echo "GEM_PATH=$GEM_PATH" >> "$HOME/.bashrc"
+echo 'export PATH="$GEM_PATH:/usr/local/opt/ruby@'${DEFAULT_RUBY_VERSION}'/bin:$PATH"'  >> "$HOME/.bashrc"


💬 2 similar findings have been found in this PR

SC2016: Expressions don't expand in single quotes, use double quotes for that.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/core/ruby.sh 10

images/linux/scripts/installers/rust.sh 32

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:36Z

images/macos/provision/core/openjdk.sh

+
+        installOpenJDK ${jdkVersionToInstall} ${jdkVendor}
+
+        isDefaultVersion=False; [[ ${jdkVersionToInstall} == ${defaultVersion} ]] && isDefaultVersion=True


💬 4 similar findings have been found in this PR

SC2053: Quote the right-hand side of == in [[ ]] to prevent glob matching.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/core/openjdk.sh 73

images/linux/scripts/installers/java-tools.sh 121

images/linux/scripts/installers/java-tools.sh 123

images/linux/scripts/installers/clang.sh 32

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:37Z

images/macos/provision/core/openjdk.sh

+defaultVendor=$(get_toolset_value '.java.default_vendor')
+jdkVendors=($(get_toolset_value '.java.vendors[].name'))
+
+for jdkVendor in ${jdkVendors[@]}; do


💬 2 similar findings have been found in this PR

SC2068: Double quote array expansions to avoid re-splitting elements.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/core/openjdk.sh 67

images/macos/provision/configuration/configure-machine.sh 47

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:39Z

images/macos/provision/core/safari.sh

+sudo safaridriver --enable
+
+echo "Enabling the 'Allow Remote Automation' option in Safari's Develop menu"
+mkdir -p $HOME/Library/WebDriver


💬 65 similar findings have been found in this PR

SC2086: Double quote to prevent globbing and word splitting.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/core/safari.sh 13

images/macos/provision/core/safari.sh 14

images/macos/provision/core/rubygem.sh 11

images/macos/provision/core/postgresql.sh 8

images/macos/provision/core/mongodb.sh 10

images/macos/provision/core/graalvm.sh 14

images/macos/provision/core/graalvm.sh 18

images/macos/provision/core/golang.sh 9

images/macos/provision/core/gcc.sh 12

images/macos/provision/core/gcc.sh 13

Showing 10 of 65 findings. Visit the Lift Web Console to see all.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:40Z

images/macos/provision/core/safari.sh

@@ -0,0 +1,16 @@
+#!/bin/bash -e -o pipefail


💬 9 similar findings have been found in this PR

SC2096: On most OS, shebangs can only specify a single parameter.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/core/open_windows_check.sh 1

images/macos/provision/core/llvm.sh 1

images/macos/provision/core/graalvm.sh 1

images/macos/provision/core/golang.sh 1

images/macos/provision/core/codeql-bundle.sh 1

images/macos/provision/core/bicep.sh 1

images/macos/provision/configuration/configure-tccdb-macos.sh 1

images/macos/provision/bootstrap-provisioner/setAutoLogin.sh 1

images/macos/provision/assets/select-xamarin-sdk-v2.sh 1

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:41Z

images/macos/provision/bootstrap-provisioner/setAutoLogin.sh

+        #use $(( shell Aritmethic )) to ^ XOR the two 0x## values (extra padding is 0x00) 
+        #take decimal value and printf convert to two char hex value
+        #use xxd to convert hex to actual value and append to the encodedString variable
+        local encodedString+=$(printf "%02X" "$(( 0x${charHex_cipher} ^ 0x${charHex:-00} ))")


💬 2 similar findings have been found in this PR

SC2155: Declare and assign separately to avoid masking return values.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/assets/select-xamarin-sdk-v2.sh 25

images/macos/provision/assets/select-xamarin-sdk-v2.sh 31

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:43Z

images/macos/provision/utils/utils.sh

+    json=$(curl "${authString[@]}" -s "https://api.github.com/repos/${REPO_ORG}/releases?per_page=${SEARCH_IN_COUNT}")
+
+    if [[ "$VERSION" == "latest" ]]; then
+        tagName=$(echo $json | jq -r '.[] | select((.prerelease==false) and (.assets | length > 0)).tag_name' | sort --unique --version-sort | egrep -v ".*-[a-z]" | tail -1)


💬 5 similar findings have been found in this PR

SC2196: egrep is non-standard and deprecated. Use grep -E instead.

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/utils/utils.sh 197

images/macos/provision/utils/utils.sh 197

images/linux/scripts/helpers/install.sh 79

images/linux/scripts/helpers/install.sh 79

images/linux/scripts/helpers/install.sh 81

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-08-19T13:18:44Z

images/macos/provision/core/vsmac.sh

+    sudo rm -rf "$TMPMOUNT"
+}
+
+VSMAC_VERSIONS=($(get_toolset_value '.xamarin.vsmac.versions[]'))


💬 3 similar findings have been found in this PR

SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).

Expand here to view all instances of this finding

File Path Line Number

images/macos/provision/bootstrap-provisioner/setAutoLogin.sh 23

images/linux/scripts/installers/java-tools.sh 110

images/linux/scripts/installers/java-tools.sh 115

Visit the Lift Web Console to find more details in your report.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

performance-testing-bot · 2023-10-26T10:24:22Z

There was an issue running the performance test

performance-testing-bot · 2023-10-26T10:25:57Z

There was an issue running the performance test

performance-testing-bot · 2023-12-06T12:55:13Z

There was an issue running the performance test

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

…image (#11193)

* [macOS] Add Symlink for tcl-tk8 * [macOS] Add condition for tcl tk only for macOS13 and macOS14 Intel machines * [macOS] Update test case for tcl/tk * [macOS] Update test cases for tcl/tk for macOS15 * [macOS] Update tcl/tk test cases

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

pull bot added the ⤵️ pull label Jun 29, 2022

sonatype-lift bot reviewed Aug 19, 2022

View reviewed changes

Updating readme file for win22 version 20240908.1.1 (#10572)

a142edb

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

JoostVoskuil and others added 30 commits December 13, 2024 20:19

Add Microsoft.Net.Component.4.7.2.SDK to Windows toolset 2022 (#11118)

7cd7c6a

Updating readme file for macos-13 version 20241211.456 (#11155)

d0a6520

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-14 version 20241211.477 (#11154)

6b5e858

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-14-arm64 version 20241211.616 (#11160)

4ef6e91

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-13-arm64 version 20241211.503 (#11153)

b14867a

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-15 version 20241211.462 (#11150)

225dce0

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-15-arm64 version 20241211.459 (#11151)

591df9a

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

[Windows] Update EdgeDriver signature (#11192)

cee689d

[Windows] Remove Windows\Installer\* folder cleanup for windows 2025 …

0e631a8

…image (#11193)

[macOS] Add Symlink for tcl-tk8 (#11128)

5c8a14c

* [macOS] Add Symlink for tcl-tk8 * [macOS] Add condition for tcl tk only for macOS13 and macOS14 Intel machines * [macOS] Update test case for tcl/tk * [macOS] Update test cases for tcl/tk for macOS15 * [macOS] Update tcl/tk test cases

Updating readme file for ubuntu22 version 20241211.1.1 (#11166)

600fb50

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for ubuntu24 version 20241208.1.1 (#11139)

ad23bf9

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

[macOS] Add Xcode 16.2 Release to macOS15 (#11179)

2899593

Updating readme file for ubuntu22 version 20241215.1.1 (#11198)

ee68afd

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for ubuntu24 version 20241215.1.1 (#11197)

7c2da16

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for ubuntu20 version 20241215.1.1 (#11205)

39222c2

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-13 version 20241216.479 (#11207)

832c038

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-13-arm64 version 20241216.537 (#11206)

f983f3d

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for win22 version 20241215.1.1 (#11202)

f55af58

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for win19 version 20241215.1.1 (#11201)

70cee3d

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-14 version 20241216.504 (#11209)

9dbed1b

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-14-arm64 version 20241216.651 (#11210)

bcf2ea8

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

[windows-2025] Install mongosh for ALLUSERS and enable test (#11224)

c9d728f

[Windows] Introduce Windows Server 2025 beta image (#11227)

3373b50

Updating readme file for macos-15 version 20241217.493 (#11214)

2d6d4f7

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Updating readme file for macos-15-arm64 version 20241217.490 (#11213)

45226c1

Co-authored-by: Image generation service account. <no-reply@microsoft.com> Co-authored-by: Actions service account <no-reply@github.com>

Fix: erlang install failure on gpg key

9bdf288

[Windows] Update EdgeDriver signature (#11237)

0a970d8

[Windows] Add WSL2 to Windows-2025 image (#11242)

5e69d9c

[windows] Add Android SDK 34 to windows-2025 (#11249)

5a7153b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] main from actions:main #1

[pull] main from actions:main #1

pull bot commented Jun 29, 2022 •

edited

Loading

commit-lint bot commented Jul 1, 2022 •

edited

Loading

viezly bot commented Jul 1, 2022 •

edited

Loading

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

sonatype-lift bot Aug 19, 2022

performance-testing-bot bot commented Oct 26, 2023

performance-testing-bot bot commented Oct 26, 2023

performance-testing-bot bot commented Dec 6, 2023


		JAVA_TOOLCACHE_PATH="${AGENT_TOOLSDIRECTORY}/Java_${VENDOR_NAME}_jdk"

		fullJavaVersion=$(cat "${javaVersionPath}/release" \| grep "^SEMANTIC" \| cut -d "=" -f 2 \| tr -d "\"" \| tr "+" "-")

		@@ -0,0 +1,8 @@
		#!/bin/bash -e -o pipefail
		source ~/utils/utils.sh

File Path	Line Number
images/macos/provision/core/graalvm.sh	2
images/macos/provision/core/golang.sh	2
images/macos/provision/core/codeql-bundle.sh	2
images/macos/provision/configuration/configure-tccdb-macos.sh	5
images/macos/provision/configuration/configure-machine.sh	3

File Path	Line Number
images/linux/scripts/installers/terraform.sh	7
images/linux/scripts/installers/swift.sh	8
images/linux/scripts/installers/sqlpackage.sh	8
images/linux/scripts/installers/sqlpackage.sh	9
images/linux/scripts/installers/selenium.sh	8
images/linux/scripts/installers/sbt.sh	7
images/linux/scripts/installers/rust.sh	9
images/linux/scripts/installers/ruby.sh	7
images/linux/scripts/installers/postgresql.sh	8
images/linux/scripts/installers/postgresql.sh	9


		installOpenJDK ${jdkVersionToInstall} ${jdkVendor}

		isDefaultVersion=False; [[ ${jdkVersionToInstall} == ${defaultVersion} ]] && isDefaultVersion=True

File Path	Line Number
images/macos/provision/core/safari.sh	13
images/macos/provision/core/safari.sh	14
images/macos/provision/core/rubygem.sh	11
images/macos/provision/core/postgresql.sh	8
images/macos/provision/core/mongodb.sh	10
images/macos/provision/core/graalvm.sh	14
images/macos/provision/core/graalvm.sh	18
images/macos/provision/core/golang.sh	9
images/macos/provision/core/gcc.sh	12
images/macos/provision/core/gcc.sh	13

File Path	Line Number
images/macos/provision/core/open_windows_check.sh	1
images/macos/provision/core/llvm.sh	1
images/macos/provision/core/graalvm.sh	1
images/macos/provision/core/golang.sh	1
images/macos/provision/core/codeql-bundle.sh	1
images/macos/provision/core/bicep.sh	1
images/macos/provision/configuration/configure-tccdb-macos.sh	1
images/macos/provision/bootstrap-provisioner/setAutoLogin.sh	1
images/macos/provision/assets/select-xamarin-sdk-v2.sh	1

File Path	Line Number
images/macos/provision/utils/utils.sh	197
images/macos/provision/utils/utils.sh	197
images/linux/scripts/helpers/install.sh	79
images/linux/scripts/helpers/install.sh	79
images/linux/scripts/helpers/install.sh	81

[pull] main from actions:main #1

Are you sure you want to change the base?

[pull] main from actions:main #1

Conversation

pull bot commented Jun 29, 2022 • edited Loading

commit-lint bot commented Jul 1, 2022 • edited Loading

Contributors

viezly bot commented Jul 1, 2022 • edited Loading

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

sonatype-lift bot Aug 19, 2022

Choose a reason for hiding this comment

performance-testing-bot bot commented Oct 26, 2023

performance-testing-bot bot commented Oct 26, 2023

performance-testing-bot bot commented Dec 6, 2023

pull bot commented Jun 29, 2022 •

edited

Loading

commit-lint bot commented Jul 1, 2022 •

edited

Loading

viezly bot commented Jul 1, 2022 •

edited

Loading