Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance Checker #386

Open
masfaraud opened this issue Oct 4, 2022 · 3 comments · Fixed by #412
Open

Instance Checker #386

masfaraud opened this issue Oct 4, 2022 · 3 comments · Fixed by #412
Assignees
@masfaraud
Labels
Status: In progress Dev team is currently working on this Type: Feature New feature or request
Milestone
Not assigned

Comments

@masfaraud
Copy link
Contributor

masfaraud commented Oct 4, 2022 •
edited
Loading

  • Dessia Object method for check is_valid? -> implement for subclass of DessiaObject
  • Check Block in workflow that stops run but do not raise error?

Should we give to users some class to throw "errors" rather than True/False -> Warnings, traceback and context of error
@masfaraud masfaraud added the Type: Feature New feature or request label Oct 4, 2022
@masfaraud
Copy link
Contributor Author

Implement "error" classes and tests to easily produce the error

@masfaraud masfaraud self-assigned this Oct 28, 2022
@masfaraud masfaraud changed the title Checkers Instance Checker Oct 28, 2022
@masfaraud
Copy link
Contributor Author

default implementation: check types of attributes?

@GhislainJ GhislainJ linked a pull request Nov 10, 2022 that will close this issue
feat: checks #412
Merged
6 tasks
@GhislainJ GhislainJ added this to the Version 0.12.0 milestone Nov 10, 2022
@GhislainJ GhislainJ added the Status: In progress Dev team is currently working on this label Feb 13, 2023
@GhislainJ
Copy link
Collaborator

Some first base features have been added. We should split this issue into sub-issues to have a good tracking. I keep this open but move it to "Not assigned" milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masfaraud masfaraud

Labels
Status: In progress Dev team is currently working on this Type: Feature New feature or request
Projects
None yet
Milestone
Not assigned
Development

Successfully merging a pull request may close this issue.

feat: checks Dessia-tech/dessia_common
2 participants
@masfaraud @GhislainJ