feat: checks #412
Merged
feat: checks #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
masfaraud
commented
Nov 2, 2022
masfaraud
commented
- What kind of changes does this PR introduce?
- Bug fix
- new features
- performance
- docs update
- Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
- Yes:
- No
- Other information:
GhislainJ
added
the
Status: Ready for review
GhislainJ
approved these changes
Nov 14, 2022
dessia_common/checks.py
Outdated
| if expected_type is str: | ||
| return is_str(value) | ||
|
|
||
| if not issubclass(value.__class__, expected_type): |
There was a problem hiding this comment.
Why not just isinstance ?
GhislainJ
added
Status: Ready for merge
|
is_valid: keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.