Merge pull request #379 from Dessia-tech/chore/bug_resize

Chore/bug resize

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.22.5]
+### Fix
+- Fix global bug on RemoteFigure.resize methods, fixing a browser crasher bug
+
 ## [0.22.4]
 ### Fix
 - Fix bug on tooltip origin when mouse leaving while hovering a shape

cypress/e2e/remoteFigure.cy.ts

@@ -147,6 +147,16 @@ describe("RemoteFigure.resizeUpdate", function() {
     });
 });
 
+describe("RemoteFigure.resizeWindow", function() {
+    it("should resize figure with new window size", function() {
+        const figure = new RemoteFigure(data, canvas.width, canvas.height, 100, 100, canvas.id);
+        figure.setCanvas(canvas.id);
+        figure.resizeWindow(700, 500);
+        expect(figure.size.x, "size.x").to.be.equal(700);
+        expect(figure.size.y, "size.y").to.be.equal(500);
+    });
+});
+
 describe("RemoteFigure.reset", function() {
     it("should reset scales and selectors", function() {
         const figure = new RemoteFigure(data, canvas.width, canvas.height, 100, 100, canvas.id);

plot_data/templates.py

@@ -77,6 +77,8 @@
             onclick="plot_data.htmlToggleAxes()"> Show / Hide Axes </button>
             <button name="logScale" value="OK" type="button"
             onclick="plot_data.switchLogScale()"> Log Scale</button>
+            <button name="resize" value="OK" type="button"
+            onclick="plot_data.resizeWindow(...PlotData.computeCanvasSize('#buttons'))"> Resize </button>
         </div>
         $specific_buttons
     </div>

src/figures.ts

@@ -467,20 +467,16 @@ export class Scatter extends Frame {
     this.computePoints();
   }
 
-  public boundingBoxResize(origin: Vertex, width: number, height: number): void {
-    super.boundingBoxResize(origin, width, height);
-    this.computePoints();
-  }
-
   public reset(): void {
     super.reset();
     this.computePoints();
     this.resetClusters();
   }
 
-  public resize(): void {
-    super.resize();
+  public resizeUpdate(): void {
+    this.resize();
     this.computePoints();
+    this.draw();
   }
 
   protected drawAbsoluteObjects(context: CanvasRenderingContext2D): void {
@@ -1113,10 +1109,10 @@ export class Draw extends Frame {
     this.draw();
   }
 
-  public resize(): void {
-    super.resize();
-    this.updateBounds();
+  public resizeUpdate(): void {
+    this.resize();
     this.axisEqual();
+    this.draw();
   }
 
   protected unpackData(data: DataInterface): Map<string, any[]> {

src/remoteFigure.ts

@@ -289,6 +289,17 @@ export class RemoteFigure {
     this.height = height;
   }
 
+  public changeCanvasSize(width: number, height: number): void {
+    const canvas = document.getElementById(this.canvasID) as HTMLCanvasElement;
+    canvas.width = width;
+    canvas.height = height;
+  }
+
+  public resizeWindow(width: number, height: number): void {
+    this.changeCanvasSize(width, height);
+    this.boundingBoxResize(this.origin, width, height);
+  }
+
   public boundingBoxResize(origin: Vertex, width: number, height: number): void {
     this.changeLocationInCanvas(origin, width, height);
     this.resizeUpdate();