Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple QUERY patterns in Value utility #464

Merged

Conversation

dharmesh-hemaram
Copy link
Member

@dharmesh-hemaram dharmesh-hemaram commented Nov 10, 2024

Description

This pull request includes enhancements to the Value utility in the libs/acf/util library to support handling multiple query patterns. The most important changes include adding a new regex pattern for multi-query parameters, implementing a function to process these parameters, and updating the test suite to cover the new functionality.

Enhancements to Value utility:

Test coverage:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code (E2E)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (DOCS)
  • I have made corresponding changes to the blog (BLOG)
  • My changes generate no new warnings (SONAR)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Create video on functionality
  • Any dependent changes have been merged and published in downstream modules

Copy link

nx-cloud bot commented Nov 10, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8b69ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

libs/acf/util/src/lib/value.ts Fixed Show fixed Hide fixed
libs/acf/util/src/lib/value.ts Dismissed Show dismissed Hide dismissed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
49.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

libs/acf/util/src/lib/value.ts Dismissed Show dismissed Hide dismissed
@dharmesh-hemaram dharmesh-hemaram merged commit ca8d0dc into main Nov 10, 2024
6 of 7 checks passed
@dharmesh-hemaram dharmesh-hemaram deleted the 435-entering-text-and-2-query-params-into-a-single-field branch November 10, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entering text and 2 query params into a single field
1 participant