Fix #4724 (delegating creator, Records) #4740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JooHyukKim I think this is a bit better way to fix #4724; fortunately #4731 helped a lot in figuring out what is actually going on. I am not super happy with the block of code I changed but it has to do for now. |
|
Ok, did tiny bit of refactoring to -- I hope -- streamline code a bit, to make it bit easier to follow. |
JooHyukKim
reviewed
Oct 9, 2024
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonValue; | ||
| import com.fasterxml.jackson.databind.testutil.DatabindTestUtil; | ||
| import com.fasterxml.jackson.databind.testutil.failure.JacksonTestFailureExpected; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| // [databind#4724] Deserialization behavior change with Java Records, JsonCreator and JsonValue between 2.17.2 => 2.18.0 | ||
| public class RecordJsonCreatorAndJsonValue4724Test |
There was a problem hiding this comment.
I was thinking we should start building habit of moving fixed /tofix tests out of /tofix package :))
There was a problem hiding this comment.
We do, but I'll do that after merging PR -- there's merge conflict when moving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.