Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #41 inspired by https://github.com/FasterXML/jackson-datatype-hibernate/pull/69 #71

Closed
wants to merge 1 commit into from

Conversation

reda-alaoui
Copy link
Contributor

(fix for #41)

Plagiarizes #69.

Without formating issues and systematic hibernate proxy loading.
Now @JsonIgnore, @JsonIdentityInfo and @jsonfilter are used even when serializing Hibernate proxies.

Thank you @ManuelB !

@ManuelB
Copy link

ManuelB commented Jun 20, 2015

Hi Reda,
that is the power of open source :-)

/Manuel

@cowtowncoder
Copy link
Member

@reda-alaoui Thank you for your contribution. I am still not comfortable with sub-classing of BeanSerializer or BeanSerializerBase -- they are not meant as extension points. But I will see if there was a way to use parts of the solution from here, and unit test from the source patch. I would want to improve handling, just want to know cleanest way to do that.

@ManuelB
Copy link

ManuelB commented Dec 28, 2015

Hi,
thanks a lot for careing for this issue. I currently don't have the resources to rework it myself. If it helps I can put a bounty on the issue:

https://www.bountysource.com

/Manuel

@cowtowncoder
Copy link
Member

I think I could actually work from this, but what I really, really need, are test cases to cover missing cases.
I think @JsonIgnore/@JsonIgnoreProperties should now work, as per #70, but what is probably missing would be:

  1. @JsonFilter -- with 2.6 and above, we can delegate that to JsonSerializer.withFilterId()
  2. @JsonUnwrapped, support via JsonSerializer.unwrappingSerializer()
  3. Object id: not sure if this can be easily supported or not, but test would be useful
  4. Polymorphic types: should be supportable same way as AtomicReferenceSerializer works

Contributions for test cases would be really appreciated.

For what it is worth, the original issue #41 (related to (3) above) does have a test, so I'll try to adopt that first.

@reda-alaoui
Copy link
Contributor Author

reda-alaoui commented Mar 21, 2017

Hello,

We were using 2.5.1 + this PR fix. We moved to version 2.8.7 without the current fix.
Everything still works great.
So closing this PR now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants