Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow for tickValues to be honored in multiple Y Axes #438

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

masiddee
Copy link
Contributor

@masiddee masiddee commented Dec 4, 2024

Description

Fixes #403

This resolves a bug where we would not honor custom tickValues passed into any non-primary Y Axes objects.
Screenshot 2024-12-05 at 10 10 59 AM

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • [ ]

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 4, 2024

🦋 Changeset detected

Latest commit: 766c618

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 3:17pm

@masiddee masiddee requested review from keithluchtel and zibs December 5, 2024 15:12
@masiddee masiddee marked this pull request as ready for review December 5, 2024 15:13
@masiddee masiddee changed the title remove normalizeYaxis tick value logic Fix: allow for tickValues to be honored in multiple Y Axes Dec 5, 2024
Copy link
Contributor

@zibs zibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@masiddee masiddee merged commit 04be366 into main Dec 6, 2024
3 checks passed
@masiddee masiddee deleted the feat/multi-axis-tick-values branch December 6, 2024 18:00
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] tickValues are not taken in account when multiple y axis
2 participants