-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
226 unify the geometries of COBs in Muller2016 #302
base: master
Are you sure you want to change the base?
Conversation
Maybe @michaelchin has ideas on whether this should be a function, etc. Also, whether to have the option to choose whether to convert polylines to polygons, or vice versa. Main use case is COBs - but could have other uses. By the way, converting polygons to polylines would only convert the exterior ring of the polygon (ignoring interior rings). I guess that's not typically a problem (but could be depending on the input data). Also, I'm assuming points and multi-points should not be converted. A note to myself: Once this is all in place I should change the setting of geometry properties. So, instead of doing this I should only convert a geometry if it's a polyline (when converting to a polygon) or if it's a polygon (when converting to a polygon). Also should retain property name of each geometry property. For inspiration, reference this. |
…n copied to convert_geometries.py
@bsim8882 I added some code changes to handle multiple geometries. You need to do "git pull" to download the changes. I found some problem in pygplates.set_geometry() function. I will ask John about it tomorrow. And I will let you know what to do next tomorrow. |
…tion_model to convert_polylines_to_polygons()
No description provided.