Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

226 unify the geometries of COBs in Muller2016 #302

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

bsim8882
Copy link

No description provided.

@bsim8882 bsim8882 linked an issue Nov 26, 2024 that may be closed by this pull request
@jcannon-gplates
Copy link
Contributor

jcannon-gplates commented Nov 26, 2024

Maybe @michaelchin has ideas on whether this should be a function, etc.

Also, whether to have the option to choose whether to convert polylines to polygons, or vice versa. Main use case is COBs - but could have other uses. By the way, converting polygons to polylines would only convert the exterior ring of the polygon (ignoring interior rings). I guess that's not typically a problem (but could be depending on the input data). Also, I'm assuming points and multi-points should not be converted.

A note to myself: Once this is all in place I should change the setting of geometry properties. So, instead of doing this I should only convert a geometry if it's a polyline (when converting to a polygon) or if it's a polygon (when converting to a polygon). Also should retain property name of each geometry property. For inspiration, reference this.

@michaelchin michaelchin changed the title Create convert_polylines_to_polygons.py 226 unify the geometries of COBs in Muller2016 Nov 28, 2024
@michaelchin
Copy link
Contributor

@bsim8882 I added some code changes to handle multiple geometries. You need to do "git pull" to download the changes.

I found some problem in pygplates.set_geometry() function. I will ask John about it tomorrow. And I will let you know what to do next tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unify the geometries of COBs in Muller2016
3 participants