ci: skip integration tests on fork PRs #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enocom it seems for the Proxy we only have one test suite that runs I wonder if we should follow the Go Connector and other repos where we have one suite for just unit tests and one suite for unit + integration? This way fork PRs will still have unit tests run... |
|
Yes, good point. Since we're having to skip integration tests for forks, it's probably a good idea to split out the unit tests before merging this. WDYT? |
enocom
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request from forks once merged will still be skipped because
github.event.pull_request.head.repo.full_namewill still be that of the fork.To combat this we run the job on all events that are not a pull_request (aka
scheduleandpush)