Skip to content

Commit

Permalink
remove warning about unable to check for latest version (#1176)
Browse files Browse the repository at this point in the history
  • Loading branch information
elharo authored Jan 18, 2017
1 parent d99ff2f commit 5b4785c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import java.nio.file.NotDirectoryException;
import java.nio.file.Paths;
import java.util.Collection;
import org.eclipse.aether.repository.RepositoryPolicy;
import org.eclipse.core.resources.ResourcesPlugin;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IStatus;
Expand All @@ -40,7 +39,6 @@
import org.eclipse.jface.viewers.ISelectionChangedListener;
import org.eclipse.jface.viewers.SelectionChangedEvent;
import org.eclipse.jface.wizard.WizardPage;
import org.eclipse.m2e.core.MavenPlugin;
import org.eclipse.swt.SWT;
import org.eclipse.swt.events.ModifyEvent;
import org.eclipse.swt.events.ModifyListener;
Expand Down Expand Up @@ -285,19 +283,10 @@ private boolean validatePage() {
if (!validateAppEngineProjectDetails()) {
return false;
}
checkMavenUpdateSettings();

return true;
}

private void checkMavenUpdateSettings() {
String globalUpdatePolicy = MavenPlugin.getMavenConfiguration().getGlobalUpdatePolicy();
if (!appEngineLibrariesSelectorGroup.getSelectedLibraries().isEmpty()
&& RepositoryPolicy.UPDATE_POLICY_NEVER.equals(globalUpdatePolicy)) {
setMessage(Messages.getString("M2E_GLOBAL_UPDATES_PREVENT_CHECKS"), WARNING); //$NON-NLS-1$
}
}

@VisibleForTesting
static boolean validateLocation(String location, WizardPage page) {
if (location.isEmpty()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ MAVEN_PROJECT_COORDINATES=Maven project coordinates
GROUP_ID=Group ID:
ARTIFACT_ID=Artifact ID:
ARTIFACT_VERSION=Version:
M2E_GLOBAL_UPDATES_PREVENT_CHECKS=Maven settings prevent checking for later versions of selected libraries
GROUP_ID_TOOLTIP=The Maven Group ID. Should be an alphanumeric path separated by periods.
ARTIFACT_ID_TOOLTIP=The Maven Artifact ID. Should be an alphanumeric name separated by dashes.

0 comments on commit 5b4785c

Please sign in to comment.