Skip to content

Commit

Permalink
chore: upgrade github action setup-gcloud to v1 (#2389)
Browse files Browse the repository at this point in the history
Followup to comment [here](#2384 (comment)), upgrades `google-github-actions/setup-gcloud` to be consistent with  [nativeTests.yaml](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/main/.github/workflows/NativeTests.yaml) following example [here](https://github.com/google-github-actions/setup-gcloud#service-account-key-json).

This also fixes deprecation warnings on integration test workflows.
```
"service_account_key" has been deprecated. Please switch to using google-github-actions/auth which supports both Workload Identity Federation and Service Account Key JSON authentication. For more details, see https://github.com/google-github-actions/setup-gcloud#authorization
```
  • Loading branch information
zhumin8 authored Nov 30, 2023
1 parent 370c1bf commit 325f513
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions .github/workflows/integrationTests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,15 @@ jobs:
with:
distribution: 'temurin'
java-version: 17
- name: Set Up Authentication
uses: google-github-actions/auth@v1
with:
credentials_json: ${{ secrets.SPRING_CLOUD_GCP_CI_SA_KEY }}
- name: Setup gcloud
uses: google-github-actions/setup-gcloud@v0
uses: google-github-actions/setup-gcloud@v1
with:
version: latest
project_id: spring-cloud-gcp-ci
service_account_key: ${{ secrets.SPRING_CLOUD_GCP_CI_SA_KEY }}
export_default_credentials: true
- name: Install pubsub-emulator
if: ${{ matrix.it == 'pubsub-emulator' }}
Expand Down Expand Up @@ -129,12 +132,15 @@ jobs:
with:
distribution: 'temurin'
java-version: 17
- name: Set Up Authentication
uses: google-github-actions/auth@v1
with:
credentials_json: ${{ secrets.SPRING_CLOUD_GCP_CI_SA_KEY }}
- name: Setup gcloud
uses: google-github-actions/setup-gcloud@v0
uses: google-github-actions/setup-gcloud@v1
with:
version: latest
project_id: spring-cloud-gcp-ci
service_account_key: ${{ secrets.SPRING_CLOUD_GCP_CI_SA_KEY }}
export_default_credentials: true
- name: Mvn install # Need this when the directory/pom structure changes
id: install
Expand Down

0 comments on commit 325f513

Please sign in to comment.