docs: fix references about other integrations in spanner doc #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original text says: > Other Google Cloud database-related integrations like Spanner and Firestore can introduce `PlatformTransactionManager` … However, the docs _are_ about Spanner integration.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
zhumin8
reviewed
Jan 15, 2025
docs/src/main/asciidoc/spanner.adoc
Outdated
| @@ -960,7 +960,7 @@ This feature requires a bean of `SpannerTransactionManager`, which is provided w | |||
| If a method annotated with `@Transactional` calls another method also annotated, then both methods will work within the same transaction. | |||
| `performReadOnlyTransaction` and `performReadWriteTransaction` cannot be used in `@Transactional` annotated methods because Cloud Spanner does not support transactions within transactions. | |||
|
|
|||
| Other Google Cloud database-related integrations like Spanner and Firestore can introduce `PlatformTransactionManager` beans, and can interfere with Datastore Transaction Manager. To disambiguate, explicitly specify the name of the transaction manager bean for such `@Transactional` methods. Example: | |||
| Other Google Cloud database-related integrations like Firestore can introduce `PlatformTransactionManager` beans, and can interfere with Spanner Transaction Manager. To disambiguate, explicitly specify the name of the transaction manager bean for such `@Transactional` methods. Example: | |||
There was a problem hiding this comment.
Suggested change
| Other Google Cloud database-related integrations like Firestore can introduce `PlatformTransactionManager` beans, and can interfere with Spanner Transaction Manager. To disambiguate, explicitly specify the name of the transaction manager bean for such `@Transactional` methods. Example: | |
| Other Google Cloud database-related integrations like Datastore and Firestore can introduce `PlatformTransactionManager` beans, and can interfere with Spanner Transaction Manager. To disambiguate, explicitly specify the name of the transaction manager bean for such `@Transactional` methods. Example: |
zhumin8
approved these changes
Jan 15, 2025
zhumin8
changed the title
zhumin8
added a commit
that referenced
this pull request
Jan 15, 2025
* docs: fix references about other integrations (#1) The original text says: > Other Google Cloud database-related integrations like Spanner and Firestore can introduce `PlatformTransactionManager` … However, the docs _are_ about Spanner integration. * add Datastore to text as other Google Cloud database-related integrations. --------- Co-authored-by: Min Zhu <zhumin@google.com>
This was referenced Jan 15, 2025
zhumin8
added a commit
that referenced
this pull request
Jan 15, 2025
…3472) * docs: fix references about other integrations (#1) The original text says: > Other Google Cloud database-related integrations like Spanner and Firestore can introduce `PlatformTransactionManager` … However, the docs _are_ about Spanner integration. * add Datastore to text as other Google Cloud database-related integrations. --------- Co-authored-by: Viktors Garkavijs <45557691+progvb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original text says:
However, the docs are about Spanner integration.