Update rspec Ruby, Gemfile, actions/cache, etc. #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, turns out it's been testing |
Bo98
force-pushed
the
ruby-update
branch
2 times, most recently
from
68d2745 to
fc989fd
Compare
MikeMcQuaid
approved these changes
Oct 15, 2023
SMillerDev
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're moving away from 2.6 and the rspecs tests here don't need to be running 2.6 still, particularly when we still have
brew test-botcommands being run in the workflow which will be use Homebrew's Ruby. It might also give us an early warning of Ruby 3.1 issues, though the rspec test coverage here is extremely minimal.Also update
actions/cacheto v3 since we support that now in setup-homebrew.