Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the ability to forcibly verify a user's email #1022

Merged
merged 2 commits into from
May 31, 2024
Merged

Implement the ability to forcibly verify a user's email #1022

merged 2 commits into from
May 31, 2024

Conversation

sudokoko
Copy link
Member

Self explanatory PR.

@sudokoko sudokoko requested review from Slendy and Zaprit May 31, 2024 18:17
Slendy
Slendy approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@Slendy Slendy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm see zaprit’s comment though. You could also remove all the existing tokens you fetched after verifying the email but I don’t think it makes a difference since they’ll expire eventually.

@sudokoko sudokoko requested a review from Zaprit May 31, 2024 22:06
Zaprit
Zaprit approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@Zaprit Zaprit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@sudokoko sudokoko added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit 643cb8e May 31, 2024
5 checks passed
@sudokoko sudokoko deleted the force-email-verification branch May 31, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaprit Zaprit Zaprit approved these changes

@Slendy Slendy Slendy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudokoko @Slendy @Zaprit