Remove license check #1035
Merged
Remove license check #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudokoko
requested changes
Jun 22, 2024
|
Technically it is still used by "version info" page, but sure, i can remove it, since that debug page only displays the value of this property |
|
Yes, that's fine. Just remove the part on the debug page too.
…On Sat, Jun 22, 2024 at 6:25 PM jackcaver ***@***.***> wrote:
Technically it is still used by "version info" page, but sure, i can
remove it, since that debug page only displays the value of this property
—
Reply to this email directly, view it on GitHub
<#1035 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQK7V5SOUMJ43RQ2HMWMWP3ZIX2VNAVCNFSM6AAAAABJSYXEP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBUGIYTIMRYGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
ok, removed it from those 2 places, is there anything else i need to change? |
sudokoko
approved these changes
Jun 22, 2024
Slendy
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1032.
It's quite annoying and doesn't really do anything, it can also trigger on people who didn't modify the source code.
It is also very easy to disable it by making a commit in the local repo or just by changing
IsDirtyto always returntrue