Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter locked levels from lucky dip #1055

Merged
merged 3 commits into from
Aug 29, 2024
Merged

filter locked levels from lucky dip #1055

merged 3 commits into from
Aug 29, 2024

Conversation

Metraberryy
Copy link
Contributor

filters locked levels out of lucky dip
iirc this was the functionality on official servers, and makes sense anyway

sudokoko
sudokoko reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@sudokoko sudokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings caught by the CI

ProjectLighthouse.Servers.GameServer/Extensions/ControllerExtensions.cs Outdated Show resolved Hide resolved
sudokoko
sudokoko approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@sudokoko sudokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

@sudokoko sudokoko requested a review from Slendy August 28, 2024 03:03
Slendy
Slendy requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@Slendy Slendy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the code for excluding locked levels from lucky dip should be in the lucky dip specific functions rather than the general request param parsing function. Other than that, this looks good.

ProjectLighthouse.Servers.GameServer/Extensions/ControllerExtensions.cs Outdated Show resolved Hide resolved
@Slendy Slendy added this pull request to the merge queue Aug 29, 2024
Merged via the queue into LBPUnion:main with commit fb2192d Aug 29, 2024
2 checks passed
@Metraberryy Metraberryy deleted the luckydip-hidelocked branch August 31, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudokoko sudokoko sudokoko approved these changes

@Slendy Slendy Slendy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Metraberryy @Slendy @sudokoko