Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notify a user when their highscore is beaten #1083

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Notify a user when their highscore is beaten #1083

merged 7 commits into from
Jan 11, 2025
+41 −11

Conversation

Metraberryy
Copy link
Contributor

image

i thought it was cool

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025 •
edited
Loading

Qodana for .NET

1088 new problems were found

Inspection name Severity Problems
XML highlighting 🔴 Failure 8
Unresolved reference 🔴 Failure 4
Annotator 🔴 Failure 1
Possible performance issues caused by unlimited string length 🔶 Warning 74
Redundant nullable directive 🔶 Warning 60
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 14
Path error 🔶 Warning 8
Missing required 'alt' attribute 🔶 Warning 6
Redundant using directive 🔶 Warning 5
Element is localizable 🔶 Warning 4
Unused schema declaration 🔶 Warning 4
Usage of navigational property can return incomplete data 🔶 Warning 3
RoslynAnalyzers Avoid using 'async void' for test methods as it is deprecated in xUnit.net v3 🔶 Warning 3
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 2
Non-accessed field (private accessibility) 🔶 Warning 2
Specify string culture explicitly 🔶 Warning 2
Auto-property accessor is never used (private accessibility) 🔶 Warning 2
Unused nullable directive 🔶 Warning 2
Unknown HTML entity 🔶 Warning 1
Unused selector 🔶 Warning 1
Disposal of a variable already captured by the 'using' statement 🔶 Warning 1
Empty statement is redundant 🔶 Warning 1
Return value must be disposed but the method or function is not annotated with [MustDisposeResource] 🔶 Warning 1
Redundant argument with default value 🔶 Warning 1
Redundant cast 🔶 Warning 1
Redundant member initializer 🔶 Warning 1
Redundant nullable warning suppression expression 🔶 Warning 1
Do not use object initializer for 'using' variable 🔶 Warning 1
Property can be made init-only (non-private accessibility) ◽️ Notice 252
Use collection expression syntax ◽️ Notice 191
Convert constructor into primary constructor ◽️ Notice 135
Auto-property can be made get-only (non-private accessibility) ◽️ Notice 73
RoslynAnalyzers Do not use boolean asserts for simple equality tests ◽️ Notice 38
Type member is never used (non-private accessibility) ◽️ Notice 26
Member can be made private (non-private accessibility) ◽️ Notice 21
Add/remove 'this.' qualifier ◽️ Notice 14
Property can be made init-only (private accessibility) ◽️ Notice 12
Unresolved reference ◽️ Notice 10
Redundant type declaration body ◽️ Notice 8
Type is never used (non-private accessibility) ◽️ Notice 8
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons ◽️ Notice 6
Important tags or attributes missing (<img> should specify alternative text) ◽️ Notice 6
Remove redundant parentheses ◽️ Notice 4
RoslynAnalyzers Avoid constant arrays as arguments ◽️ Notice 4
RoslynAnalyzers Use char overload ◽️ Notice 4
RoslynAnalyzers Instantiate argument exceptions correctly ◽️ Notice 4
Merge null/pattern/value checks into 'or'/'and' patterns ◽️ Notice 4
Use raw string ◽️ Notice 4
RoslynAnalyzers Use concrete types when possible for improved performance ◽️ Notice 3
Convert constructor into member initializers ◽️ Notice 3
Member can be made protected (non-private accessibility) ◽️ Notice 3
Merge null/pattern checks into complex pattern ◽️ Notice 3
Unused parameter (non-private accessibility) ◽️ Notice 3
Use preferred style for trailing comma before new line in multiline lists ◽️ Notice 2
Class with virtual (overridable) members never inherited (non-private accessibility) ◽️ Notice 2
'if-return' statement can be rewritten as 'return' statement ◽️ Notice 2
Query can return incomplete data for related entities ◽️ Notice 2
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used ◽️ Notice 2
Non-accessed field (non-private accessibility) ◽️ Notice 2
Unassigned field (non-private accessibility) ◽️ Notice 2
Mapped path ◽️ Notice 2
RoslynAnalyzers Suggest using IHeaderDictionary properties ◽️ Notice 1
Use preferred body style (convert into method or operator with preferred body style) ◽️ Notice 1
Auto-property can be made get-only (private accessibility) ◽️ Notice 1
RoslynAnalyzers Mark members as static ◽️ Notice 1
RoslynAnalyzers Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' method ◽️ Notice 1
RoslynAnalyzers Avoid using 'Enumerable.Any()' extension method ◽️ Notice 1
RoslynAnalyzers Non-constant fields should not be visible ◽️ Notice 1
Dictionary lookup can be simplified with 'GetValueOrDefault' ◽️ Notice 1
Class is never instantiated (non-private accessibility) ◽️ Notice 1
'if' statement can be rewritten as '?:' expression ◽️ Notice 1
Invert 'if' statement to reduce nesting ◽️ Notice 1
Member can be made static (shared) (non-private accessibility) ◽️ Notice 1
Method has async overload ◽️ Notice 1
Put local function after 'return' or 'continue' ◽️ Notice 1
Redundant empty argument list on object creation expression ◽️ Notice 1
Redundant string interpolation ◽️ Notice 1
Some values of the enum are not processed inside 'switch' statement and are handled via default section ◽️ Notice 1
Type member is never accessed via base type (non-private accessibility) ◽️ Notice 1
Method return value is never used (non-private accessibility) ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 72 dependencies

Third-party software list

This page lists the third-party software dependencies used in ProjectLighthouse

Dependency Version Licenses
BCrypt.Net-Next 4.0.3 MIT
BouncyCastle.Cryptography 2.4.0 MIT
Discord.Net.Core 3.15.0 MIT
Discord.Net.Rest 3.15.0 MIT
Discord.Net.Webhook 3.15.0 MIT
DistributedLock.Core 1.0.6 MIT
DistributedLock.MySql 1.0.2 MIT
GitInfo 3.3.5 MIT
Humanizer.Core 2.14.1 MIT
JetBrains.Annotations 2023.3.0 MIT
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore 8.0.6 MIT
Microsoft.Bcl.AsyncInterfaces 6.0.0 MIT
Microsoft.CSharp 4.7.0 MIT
Microsoft.CodeAnalysis.Analyzers 3.3.3 MIT
Microsoft.CodeAnalysis.CSharp.Workspaces 4.5.0 MIT
Microsoft.CodeAnalysis.CSharp 4.5.0 MIT
Microsoft.CodeAnalysis.Common 4.5.0 MIT
Microsoft.CodeAnalysis.Workspaces.Common 4.5.0 MIT
Microsoft.EntityFrameworkCore.Abstractions 8.0.6 MIT
Microsoft.EntityFrameworkCore.Analyzers 8.0.6 MIT
Microsoft.EntityFrameworkCore.Design 8.0.6 MIT
Microsoft.EntityFrameworkCore.Relational 8.0.6 MIT
Microsoft.EntityFrameworkCore 8.0.6 MIT
Microsoft.Extensions.ApiDescription.Server 6.0.5 MIT
Microsoft.Extensions.Caching.Abstractions 8.0.0 MIT
Microsoft.Extensions.Caching.Memory 8.0.0 MIT
Microsoft.Extensions.Configuration.Abstractions 8.0.0 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 8.0.0 MIT
Microsoft.Extensions.DependencyInjection 8.0.0 MIT
Microsoft.Extensions.DependencyModel 8.0.0 MIT
Microsoft.Extensions.Logging.Abstractions 8.0.0 MIT
Microsoft.Extensions.Logging 8.0.0 MIT
Microsoft.Extensions.Options 8.0.0 MIT
Microsoft.Extensions.Primitives 8.0.0 MIT
Microsoft.OpenApi 1.6.14 MIT
Mono.TextTemplating 2.2.1 MIT
MySqlConnector 2.3.5 MIT
Newtonsoft.Json 13.0.3 MIT
Pfim 0.11.2 MIT
Pipelines.Sockets.Unofficial 2.2.8 MIT
Pomelo.EntityFrameworkCore.MySql 8.0.2 MIT
QRCoder 1.5.1 MIT
Redis.OM 0.7.1 MIT
SharpZipLib 1.4.2 MIT
SixLabors.ImageSharp 3.1.5 Apache-2.0
PROPRIETARY-LICENSE
StackExchange.Redis 2.7.17 MIT
Swashbuckle.AspNetCore.Swagger 6.6.2 MIT
Swashbuckle.AspNetCore.SwaggerGen 6.6.2 MIT
Swashbuckle.AspNetCore.SwaggerUI 6.6.2 MIT
Swashbuckle.AspNetCore 6.6.2 MIT
System.CodeDom 4.4.0 MIT
System.Collections.Immutable 6.0.0 MIT
System.Composition.AttributedModel 6.0.0 MIT
System.Composition.Convention 6.0.0 MIT
System.Composition.Hosting 6.0.0 MIT
System.Composition.Runtime 6.0.0 MIT
System.Composition.TypedParts 6.0.0 MIT
System.Composition 6.0.0 MIT
System.IO.Pipelines 6.0.3 MIT
System.Interactive.Async 6.0.1 MIT
System.Linq.Async 6.0.1 MIT
System.Reflection.Metadata 6.0.1 MIT
System.Runtime.CompilerServices.Unsafe 6.0.0 MIT
System.Text.Encoding.CodePages 6.0.0 MIT
System.Text.Encodings.Web 8.0.0 MIT
System.Text.Json 8.0.0 MIT
System.Threading.Channels 6.0.0 MIT
System.Threading.Tasks.Extensions 4.5.4 MIT
System.ValueTuple 4.5.0 MIT
ThisAssembly.Constants 1.4.1 MIT
Ulid 1.2.6 MIT
YamlDotNet 15.1.6 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@FeTetra
Copy link
Contributor

FeTetra commented Jan 2, 2025

I feel like there should be a configuration option to enable or disable this.

sudokoko
sudokoko requested changes Jan 2, 2025
View reviewed changes
Copy link
Member

@sudokoko sudokoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions but otherwise this is fine

ProjectLighthouse/Database/DatabaseContext.Notifications.cs Outdated Show resolved Hide resolved
ProjectLighthouse.Servers.GameServer/Controllers/Slots/ScoreController.cs Outdated Show resolved Hide resolved
@sudokoko
Copy link
Member

sudokoko commented Jan 2, 2025

I feel like there should be a configuration option to enable or disable this.

unnecessary in my opinion, this is more of an "extension to the game" type of implementation than something like level delete notifications which is up to the server and should be in the context of such

@sudokoko sudokoko requested a review from Slendy January 2, 2025 22:09
Slendy
Slendy approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@Slendy Slendy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, extra documentation for the embedded xml stuff would be helpful imo

ProjectLighthouse/Types/Entities/Profile/UserEntity.cs Outdated Show resolved Hide resolved
ProjectLighthouse/Types/Entities/Level/SlotEntity.cs Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Qodana for .NET

1088 new problems were found

Inspection name Severity Problems
XML highlighting 🔴 Failure 8
Unresolved reference 🔴 Failure 4
Annotator 🔴 Failure 1
Possible performance issues caused by unlimited string length 🔶 Warning 74
Redundant nullable directive 🔶 Warning 60
Auto-property accessor is never used (non-private accessibility) 🔶 Warning 14
Path error 🔶 Warning 8
Missing required 'alt' attribute 🔶 Warning 6
Redundant using directive 🔶 Warning 5
Element is localizable 🔶 Warning 4
Unused schema declaration 🔶 Warning 4
Usage of navigational property can return incomplete data 🔶 Warning 3
RoslynAnalyzers Avoid using 'async void' for test methods as it is deprecated in xUnit.net v3 🔶 Warning 3
Conditional access qualifier expression is not null according to nullable reference types' annotations 🔶 Warning 2
Non-accessed field (private accessibility) 🔶 Warning 2
Specify string culture explicitly 🔶 Warning 2
Auto-property accessor is never used (private accessibility) 🔶 Warning 2
Unused nullable directive 🔶 Warning 2
Unknown HTML entity 🔶 Warning 1
Unused selector 🔶 Warning 1
Disposal of a variable already captured by the 'using' statement 🔶 Warning 1
Empty statement is redundant 🔶 Warning 1
Return value must be disposed but the method or function is not annotated with [MustDisposeResource] 🔶 Warning 1
Redundant argument with default value 🔶 Warning 1
Redundant cast 🔶 Warning 1
Redundant member initializer 🔶 Warning 1
Redundant nullable warning suppression expression 🔶 Warning 1
Do not use object initializer for 'using' variable 🔶 Warning 1
Property can be made init-only (non-private accessibility) ◽️ Notice 252
Use collection expression syntax ◽️ Notice 191
Convert constructor into primary constructor ◽️ Notice 135
Auto-property can be made get-only (non-private accessibility) ◽️ Notice 73
RoslynAnalyzers Do not use boolean asserts for simple equality tests ◽️ Notice 38
Type member is never used (non-private accessibility) ◽️ Notice 26
Member can be made private (non-private accessibility) ◽️ Notice 21
Add/remove 'this.' qualifier ◽️ Notice 14
Property can be made init-only (private accessibility) ◽️ Notice 12
Unresolved reference ◽️ Notice 10
Redundant type declaration body ◽️ Notice 8
Type is never used (non-private accessibility) ◽️ Notice 8
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons ◽️ Notice 6
Important tags or attributes missing (<img> should specify alternative text) ◽️ Notice 6
Remove redundant parentheses ◽️ Notice 4
RoslynAnalyzers Avoid constant arrays as arguments ◽️ Notice 4
RoslynAnalyzers Use char overload ◽️ Notice 4
RoslynAnalyzers Instantiate argument exceptions correctly ◽️ Notice 4
Merge null/pattern/value checks into 'or'/'and' patterns ◽️ Notice 4
Use raw string ◽️ Notice 4
RoslynAnalyzers Use concrete types when possible for improved performance ◽️ Notice 3
Convert constructor into member initializers ◽️ Notice 3
Member can be made protected (non-private accessibility) ◽️ Notice 3
Merge null/pattern checks into complex pattern ◽️ Notice 3
Unused parameter (non-private accessibility) ◽️ Notice 3
Use preferred style for trailing comma before new line in multiline lists ◽️ Notice 2
Class with virtual (overridable) members never inherited (non-private accessibility) ◽️ Notice 2
'if-return' statement can be rewritten as 'return' statement ◽️ Notice 2
Query can return incomplete data for related entities ◽️ Notice 2
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used ◽️ Notice 2
Non-accessed field (non-private accessibility) ◽️ Notice 2
Unassigned field (non-private accessibility) ◽️ Notice 2
Mapped path ◽️ Notice 2
RoslynAnalyzers Suggest using IHeaderDictionary properties ◽️ Notice 1
Use preferred body style (convert into method or operator with preferred body style) ◽️ Notice 1
Auto-property can be made get-only (private accessibility) ◽️ Notice 1
RoslynAnalyzers Mark members as static ◽️ Notice 1
RoslynAnalyzers Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' method ◽️ Notice 1
RoslynAnalyzers Avoid using 'Enumerable.Any()' extension method ◽️ Notice 1
RoslynAnalyzers Non-constant fields should not be visible ◽️ Notice 1
Dictionary lookup can be simplified with 'GetValueOrDefault' ◽️ Notice 1
Class is never instantiated (non-private accessibility) ◽️ Notice 1
'if' statement can be rewritten as '?:' expression ◽️ Notice 1
Invert 'if' statement to reduce nesting ◽️ Notice 1
Member can be made static (shared) (non-private accessibility) ◽️ Notice 1
Method has async overload ◽️ Notice 1
Put local function after 'return' or 'continue' ◽️ Notice 1
Redundant empty argument list on object creation expression ◽️ Notice 1
Redundant string interpolation ◽️ Notice 1
Some values of the enum are not processed inside 'switch' statement and are handled via default section ◽️ Notice 1
Type member is never accessed via base type (non-private accessibility) ◽️ Notice 1
Method return value is never used (non-private accessibility) ◽️ Notice 1

☁️ View the detailed Qodana report

Detected 72 dependencies

Third-party software list

This page lists the third-party software dependencies used in ProjectLighthouse

Dependency Version Licenses
BCrypt.Net-Next 4.0.3 MIT
BouncyCastle.Cryptography 2.4.0 MIT
Discord.Net.Core 3.15.0 MIT
Discord.Net.Rest 3.15.0 MIT
Discord.Net.Webhook 3.15.0 MIT
DistributedLock.Core 1.0.6 MIT
DistributedLock.MySql 1.0.2 MIT
GitInfo 3.3.5 MIT
Humanizer.Core 2.14.1 MIT
JetBrains.Annotations 2023.3.0 MIT
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore 8.0.6 MIT
Microsoft.Bcl.AsyncInterfaces 6.0.0 MIT
Microsoft.CSharp 4.7.0 MIT
Microsoft.CodeAnalysis.Analyzers 3.3.3 MIT
Microsoft.CodeAnalysis.CSharp.Workspaces 4.5.0 MIT
Microsoft.CodeAnalysis.CSharp 4.5.0 MIT
Microsoft.CodeAnalysis.Common 4.5.0 MIT
Microsoft.CodeAnalysis.Workspaces.Common 4.5.0 MIT
Microsoft.EntityFrameworkCore.Abstractions 8.0.6 MIT
Microsoft.EntityFrameworkCore.Analyzers 8.0.6 MIT
Microsoft.EntityFrameworkCore.Design 8.0.6 MIT
Microsoft.EntityFrameworkCore.Relational 8.0.6 MIT
Microsoft.EntityFrameworkCore 8.0.6 MIT
Microsoft.Extensions.ApiDescription.Server 6.0.5 MIT
Microsoft.Extensions.Caching.Abstractions 8.0.0 MIT
Microsoft.Extensions.Caching.Memory 8.0.0 MIT
Microsoft.Extensions.Configuration.Abstractions 8.0.0 MIT
Microsoft.Extensions.DependencyInjection.Abstractions 8.0.0 MIT
Microsoft.Extensions.DependencyInjection 8.0.0 MIT
Microsoft.Extensions.DependencyModel 8.0.0 MIT
Microsoft.Extensions.Logging.Abstractions 8.0.0 MIT
Microsoft.Extensions.Logging 8.0.0 MIT
Microsoft.Extensions.Options 8.0.0 MIT
Microsoft.Extensions.Primitives 8.0.0 MIT
Microsoft.OpenApi 1.6.14 MIT
Mono.TextTemplating 2.2.1 MIT
MySqlConnector 2.3.5 MIT
Newtonsoft.Json 13.0.3 MIT
Pfim 0.11.2 MIT
Pipelines.Sockets.Unofficial 2.2.8 MIT
Pomelo.EntityFrameworkCore.MySql 8.0.2 MIT
QRCoder 1.5.1 MIT
Redis.OM 0.7.1 MIT
SharpZipLib 1.4.2 MIT
SixLabors.ImageSharp 3.1.5 Apache-2.0
PROPRIETARY-LICENSE
StackExchange.Redis 2.7.17 MIT
Swashbuckle.AspNetCore.Swagger 6.6.2 MIT
Swashbuckle.AspNetCore.SwaggerGen 6.6.2 MIT
Swashbuckle.AspNetCore.SwaggerUI 6.6.2 MIT
Swashbuckle.AspNetCore 6.6.2 MIT
System.CodeDom 4.4.0 MIT
System.Collections.Immutable 6.0.0 MIT
System.Composition.AttributedModel 6.0.0 MIT
System.Composition.Convention 6.0.0 MIT
System.Composition.Hosting 6.0.0 MIT
System.Composition.Runtime 6.0.0 MIT
System.Composition.TypedParts 6.0.0 MIT
System.Composition 6.0.0 MIT
System.IO.Pipelines 6.0.3 MIT
System.Interactive.Async 6.0.1 MIT
System.Linq.Async 6.0.1 MIT
System.Reflection.Metadata 6.0.1 MIT
System.Runtime.CompilerServices.Unsafe 6.0.0 MIT
System.Text.Encoding.CodePages 6.0.0 MIT
System.Text.Encodings.Web 8.0.0 MIT
System.Text.Json 8.0.0 MIT
System.Threading.Channels 6.0.0 MIT
System.Threading.Tasks.Extensions 4.5.4 MIT
System.ValueTuple 4.5.0 MIT
ThisAssembly.Constants 1.4.1 MIT
Ulid 1.2.6 MIT
YamlDotNet 15.1.6 MIT
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@Slendy Slendy added this pull request to the merge queue Jan 11, 2025
Merged via the queue into LBPUnion:main with commit 4f9dc2a Jan 11, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudokoko sudokoko sudokoko approved these changes

@Slendy Slendy Slendy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Metraberryy @FeTetra @sudokoko @Slendy