Revert PR#36 "Fix issue#86" #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4477641. We keep the modification to the removal of "import sys in "test_issue_35.py, which is unrelated. Use of GeomAPI_ProjectPointOnSurf in OCCGeomRepresentation::projectPointOn proved to be controversial
nicolaslg
force-pushed
the
revert_PR36_issue86_on_projection
branch
from
11165d8 to
fc638fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in PR #52, PR #36 introduced a x3 drop in projection performances while only partially addressing the issue of badly projected nodes on surfaces. It also introduced a modification of the behavior of topological entities projection to surfaces (for surfaces with a small area).
We chose to revert this development.
This reverts commit 4477641.
We keep the modification to the removal of
import sysintest_issue_35.py, which is unrelated to the projection modification.